Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Null Product Types #3382

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

brandon-1999
Copy link

Description (*)

Typecast product type data to stringify null values

Manual testing scenarios (*)

  1. Place an order
  2. Manually set an order item product type value to null
  3. Observe sales_order_clean exception

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@pykettk
Copy link
Member

pykettk commented Apr 24, 2023

@brandon-1999 Don't forget to sign the CLA so we can get this moving 🙂

@brandon-1999
Copy link
Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@pykettk
Copy link
Member

pykettk commented Apr 25, 2023

@magento run Functional Tests CE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@pykettk
Copy link
Member

pykettk commented Apr 25, 2023

@magento run Functional Tests EE

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@pykettk
Copy link
Member

pykettk commented Apr 25, 2023

@magento run Integration Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants