Msi stock ui aggregation #35

jonfres · 2017-06-26T15:49:52Z

created a new page for stock administration and all needed repositories, models, resource models needed for stock management
created API for stock management

Description

Issue: https://github.com/magento-engcom/magento2/issues/34

Contribution checklist

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)

- created Resource models, models and APIs

- created StockRepositoryInterface and StockRepository

- created Stock UI files and view ui layout and component for adminhtml Merge branch 'msi-stock-ui-aggregation' of https://github.com/jonfres/magento2 into msi-stock-ui-aggregation

…/magento2 into msi-stock-ui-aggregation

- created test for StockRepository

- controller Stock and menu option for Manage Stock added

…/magento2 into msi-stock-ui-aggregation

- controller Stock and menu option for Manage Stock added2

- changed implementation of StockRepository

…/magento2 into msi-stock-ui-aggregation # Conflicts: # app/code/Magento/Inventory/Ui/DataProvider/StockDataProvider.php

- fixes for the grid on Stock listing

…/magento2 into msi-stock-ui-aggregation

larsroettig · 2017-06-29T19:07:45Z

app/code/Magento/Inventory/Controller/Adminhtml/Stock/Edit.php

+use Magento\InventoryApi\Api\Data\StockInterface;
+
+/**
+ * Class Edit


remove class comment

larsroettig · 2017-06-29T19:08:26Z

app/code/Magento/Inventory/Controller/Adminhtml/Stock/Index.php

+use Magento\Framework\Controller\ResultFactory;
+
+/**
+ * Class Index


remove class comment

larsroettig · 2017-06-29T19:08:45Z

app/code/Magento/Inventory/Controller/Adminhtml/Stock/Save.php

+use Magento\InventoryApi\Api\StockRepositoryInterface;
+
+/**
+ * Class Save


remove class comment

larsroettig · 2017-06-29T19:09:40Z

app/code/Magento/Inventory/Controller/Adminhtml/Stock/Save.php

+    }
+
+    /**
+     * {@inheritdoc}


use pls @inheritdoc without {}

larsroettig · 2017-06-29T19:11:01Z

app/code/Magento/Inventory/Controller/Adminhtml/Stock/Save.php

+        $requestData = $this->getRequest()->getParam('general');
+        if ($this->getRequest()->isPost() && $requestData) {
+            try {
+                $stockId = !empty($requestData[StockInterface::STOCK_ID])


non-readable negative short if improve this for better readable code

larsroettig · 2017-06-29T19:11:33Z

app/code/Magento/Inventory/Controller/Adminhtml/Stock/Save.php

+    }
+
+    /**
+     * @param int $stockId


add some function description

larsroettig · 2017-06-29T19:17:39Z

app/code/Magento/Inventory/view/adminhtml/ui_component/inventory_stock_listing.xml

+                </editor>
+            </settings>
+        </column>
+        <!--<column name="contact_name" sortOrder="40">


Comment code pls remove

maghamed · 2017-07-04T16:07:41Z

app/code/Magento/Inventory/Model/ResourceModel/Stock/Collection.php

+            $connection,
+            $resource
+        );
+    }


why do we need constructor, if all the parameters are just proxying to parent constructor

maghamed · 2017-07-04T16:08:26Z

app/code/Magento/Inventory/Model/Stock.php

+use Magento\InventoryApi\Api\Data\StockInterface;
+
+/**
+ * Class Source


please provide more meaningful description

maghamed · 2017-07-04T16:10:40Z

app/code/Magento/Inventory/Model/StockRepository.php

@@ -0,0 +1,134 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.


we need to have delete()
operation in Stock repository.

When Stock is removed, we need to remove all stock items related to it (could be done using Foreign Key on DB level)

maghamed · 2017-07-04T16:15:16Z

app/code/Magento/InventoryApi/Api/Data/SourceStockLinkInterface.php

+use Magento\Framework\Api\ExtensibleDataInterface;
+
+/**
+ * SourceCarrierLink interface


we need to provide more meaningful description to this interface.

maghamed · 2017-07-04T16:19:27Z

app/code/Magento/InventoryApi/Api/Data/SourceStockLinkInterface.php

+ * SourceCarrierLink interface
+ * @api
+ */
+interface SourceStockLinkInterface extends ExtensibleDataInterface


there is no class which implements this interface

maghamed · 2017-07-04T16:24:16Z

app/code/Magento/InventoryApi/Api/Data/StockInterface.php

+     * @param string $name
+     * @return void
+     */
+    public function setName($name);


need to specify
getExtensionAttributes/setExtensionAttributes methods and specify own types they accept

maghamed · 2017-07-04T16:24:42Z

app/code/Magento/InventoryApi/Api/Data/StockSearchResultsInterface.php

+use Magento\Framework\Api\SearchResultsInterface;
+
+/**
+ * @api


please add description to all interfaces marked as api

maghamed · 2017-07-04T16:24:59Z

app/code/Magento/InventoryApi/Api/StockRepositoryInterface.php

+namespace Magento\InventoryApi\Api;
+
+/**
+ * @api


meaningful description should be added

maghamed · 2017-07-04T16:25:12Z

app/code/Magento/InventoryApi/Api/StockRepositoryInterface.php

+     */
+    public function getList(
+        \Magento\Framework\Api\SearchCriteriaInterface $searchCriteria = null
+    );


need to add deleteById method to the interface

maghamed · 2017-07-04T16:26:48Z

app/code/Magento/InventoryApi/Api/StockRepositoryInterface.php

+     * @param \Magento\Framework\Api\SearchCriteriaInterface $searchCriteria
+     * @return \Magento\InventoryApi\Api\Data\StockSearchResultsInterface
+     */
+    public function getList(


we have the only field (Name) by which we could make filtering, don't think that we need to over complicate our API and accept SearchCriteria in this case.
$name parameter should be okay

vrann and others added 21 commits June 26, 2017 13:01

magento-engcom/magento#34: Source to Stock Mapping UI and API

be1d21e

- created Resource models, models and APIs

agento-engcom/magento#34: Source to Stock Mapping UI and API

dfd6a47

magento-engcom/magento#34: Source to Stock Mapping UI and API

67775b7

- created StockRepositoryInterface and StockRepository

magento-engcom/magento#34: Source to Stock Mapping UI and API

fbb4515

- created Stock UI files and view ui layout and component for adminhtml Merge branch 'msi-stock-ui-aggregation' of https://github.com/jonfres/magento2 into msi-stock-ui-aggregation

magento-engcom/magento#34 Inventory Stock table created

1755600

Merge branch 'msi-stock-ui-aggregation' of https://github.com/jonfres…

3514312

…/magento2 into msi-stock-ui-aggregation

magento-engcom/magento#34 Source stock link table created

35a65fb

magento-engcom/magento#34 upgrade moved to the install script

01e5081

magento-engcom/magento#34: Source to Stock Mapping UI and API

9cb1802

- created test for StockRepository

magento-engcom/magento#34: Source to Stock Mapping UI and API

e712957

- controller Stock and menu option for Manage Stock added

Merge branch 'msi-stock-ui-aggregation' of https://github.com/jonfres…

d51900e

…/magento2 into msi-stock-ui-aggregation

Merge branch 'msi-stock-ui-aggregation' of https://github.com/jonfres…

04b31b5

…/magento2 into msi-stock-ui-aggregation

magento-engcom/magento#34 stock interface stock id constant change

b659579

magento-engcom/magento#34: Source to Stock Mapping UI and API

9788440

- controller Stock and menu option for Manage Stock added2

magento-engcom/magento#34: Source to Stock Mapping UI and API

2530ee2

- changed implementation of StockRepository

magento-engcom/magento#34 admin add/edit Stock form and action added

9fab8e2

magento-engcom/magento#34 Stock for created

314a859

Merge branch 'msi-stock-ui-aggregation' of https://github.com/jonfres…

394aa38

…/magento2 into msi-stock-ui-aggregation # Conflicts: # app/code/Magento/Inventory/Ui/DataProvider/StockDataProvider.php

magento-engcom/magento#34 saving Stock action added

81f5921

magento-engcom/magento#34: Source to Stock Mapping UI and API

e600552

- fixes for the grid on Stock listing

Merge branch 'msi-stock-ui-aggregation' of https://github.com/jonfres…

d2d5028

…/magento2 into msi-stock-ui-aggregation

larsroettig reviewed Jun 29, 2017

View reviewed changes

vrann assigned jonfres Jun 30, 2017

some code fixes, remove class names, improve ternary operator

32f80ff

naydav changed the base branch from develop to msi-stock-ui-aggregation July 4, 2017 16:06

naydav merged commit 629bfa8 into magento:msi-stock-ui-aggregation Jul 4, 2017

maghamed reviewed Jul 4, 2017

View reviewed changes

maghamed added the Award: special achievement label Oct 3, 2017

This was referenced Dec 11, 2017

Exception during creating New Stock #280

Closed

Exception during editing Default Stock #281

Closed

smoskaluk mentioned this pull request Dec 11, 2017

Exception during creating New Source #282

Closed

smoskaluk mentioned this pull request Mar 23, 2018

Exception in Low stock report for product with another name on additional storeview #737

Closed

smoskaluk mentioned this pull request May 18, 2018

Installation B2b with MSI fails #1198

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Msi stock ui aggregation #35

Msi stock ui aggregation #35

jonfres commented Jun 26, 2017

larsroettig Jun 29, 2017

larsroettig Jun 29, 2017

larsroettig Jun 29, 2017

larsroettig Jun 29, 2017

larsroettig Jun 29, 2017

larsroettig Jun 29, 2017

larsroettig Jun 29, 2017

maghamed Jul 4, 2017

maghamed Jul 4, 2017

maghamed Jul 4, 2017

maghamed Jul 4, 2017

maghamed Jul 4, 2017

maghamed Jul 4, 2017

maghamed Jul 4, 2017

maghamed Jul 4, 2017

maghamed Jul 4, 2017

maghamed Jul 4, 2017

Msi stock ui aggregation #35

Msi stock ui aggregation #35

Conversation

jonfres commented Jun 26, 2017

Description

Contribution checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment