WIP: Msi stock ui aggregation #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- created Resource models, models and APIs
- created StockRepositoryInterface and StockRepository
- created Stock UI files and view ui layout and component for adminhtml Merge branch 'msi-stock-ui-aggregation' of https://github.com/jonfres/magento2 into msi-stock-ui-aggregation
…/magento2 into msi-stock-ui-aggregation
- created test for StockRepository
- controller Stock and menu option for Manage Stock added
…/magento2 into msi-stock-ui-aggregation
…/magento2 into msi-stock-ui-aggregation
- controller Stock and menu option for Manage Stock added2
- changed implementation of StockRepository
…/magento2 into msi-stock-ui-aggregation # Conflicts: # app/code/Magento/Inventory/Ui/DataProvider/StockDataProvider.php
- fixes for the grid on Stock listing
…/magento2 into msi-stock-ui-aggregation
source item management
…rce-item-management # Conflicts: # app/code/Magento/Inventory/Model/ResourceModel/SourceItem/Collection.php # app/code/Magento/InventoryApi/Api/Data/SourceItemInterface.php
added 13 commits
July 20, 2017 11:10
- refactoring
- refactoring
- refactoring
- refactoring
- refactoring
- refactoring
- refactoring
- refactoring
- refactoring
- refactoring
- fix tests - split InstallSchema - update Magento\Framework\DB\Ddl\Table
- fix static tests
- fix static tests
maghamed
suggested changes
Jul 26, 2017
| @@ -13,7 +13,7 @@ | |||
| use Magento\Shipping\Model\Config; | |||
|
|
|||
| /** | |||
| * Class CarrierRequestDataHydrator | |||
| * Populate Source by carrier codes links | |||
There was a problem hiding this comment.
Populate Source by carrier code links
| @@ -10,7 +10,7 @@ | |||
| use Magento\Framework\Controller\ResultFactory; | |||
|
|
|||
| /** | |||
| * Class Index | |||
| * Index Controller | |||
There was a problem hiding this comment.
if you give such description, you should specify Index Controller of which Entity.
This is Source Index Controller.
| @@ -16,7 +16,7 @@ | |||
| use Magento\InventoryApi\Api\Data\SourceInterface; | |||
|
|
|||
| /** | |||
| * Class InlineEdit | |||
| * InlineEdit Controller | |||
| use Magento\Framework\Exception\NoSuchEntityException; | ||
| use Magento\Framework\Registry; | ||
| use Magento\InventoryApi\Api\Data\SourceInterface; | ||
| use Magento\InventoryApi\Api\Data\SourceInterfaceFactory; | ||
| use Magento\InventoryApi\Api\SourceRepositoryInterface; | ||
|
|
||
| /** | ||
| * Class Save | ||
| * Save Controller |
| use Magento\InventoryApi\Api\Data\StockInterface; | ||
|
|
||
| /** | ||
| * InlineEdit Controller |
There was a problem hiding this comment.
please fix description for all controller classes
| */ | ||
| public function execute($stockId, $sourceId) | ||
| { | ||
| if (0 === (int)$stockId || 0 === (int)$sourceId) { |
| $items = $collection->getItems(); | ||
|
|
||
| if (empty($items)) { | ||
| throw new CouldNotDeleteException( |
There was a problem hiding this comment.
why do you think we need to throw an exception when there is no relation to delete?
for example, amqp says that each message in queue should be idempotent , thus
it implies that each message could be delivered "at least once"
so, there is a possibility that worker would handle the same message twice
so, why do we thrown an exception when handler will process message second time?
moreover it's cheaper just to delete link
| * Copyright © Magento, Inc. All rights reserved. | ||
| * See COPYING.txt for license details. | ||
| */ | ||
| namespace Magento\Inventory\Setup\InstallStep; |
There was a problem hiding this comment.
I don't like the name "Step" here
| use Magento\InventoryApi\Api\StockRepositoryInterface; | ||
|
|
||
| /** | ||
| * Class StockDataProvider |
There was a problem hiding this comment.
please provide precise and clear description
| $data = parent::getData(); | ||
| if ('inventory_stock_form_data_source' === $this->name) { | ||
| // It is need for support of several fieldsets. | ||
| // For details see \Magento\Ui\Component\Form::getDatastockData |
There was a problem hiding this comment.
there is only getDataSourceData function in Magento\Ui\Component\Form
added 6 commits
July 27, 2017 12:13
- fixes after CR
- fixes after CR
- fixes after CR
- fixes after CR
- fixes after CR
- fixes
okolesnyk
pushed a commit
that referenced
this pull request
Mar 6, 2018
- Merge Pull Request magento-engcom/php-7.2-support#39 from pmclain/php-7.2-support:update/cm-redis-session-abstract - Merged commits: 1. 6b1ae42
okolesnyk
pushed a commit
that referenced
this pull request
Mar 6, 2018
engcom-Golf
pushed a commit
to engcom-Golf/inventory
that referenced
this pull request
Dec 15, 2020
MC-39893: Revert composer2 changes in mainline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.