#25656: Removes the exception being thrown for methods returning null

magento · Nov 29, 2019 · 253f881 · 253f881
1 parent 99a1a98
commit 253f881
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 23 deletions.
diff --git a/lib/internal/Magento/Framework/Reflection/Test/Unit/TypeProcessorTest.php b/lib/internal/Magento/Framework/Reflection/Test/Unit/TypeProcessorTest.php
@@ -383,20 +383,6 @@ public function testGetReturnTypeNullAtFirstPos()
         self::assertEquals($expected, $this->typeProcessor->getGetterReturnType($methodReflection));
     }
 
-    /**
-     * Checks a case when method return annotation has a null-type at first position,
-     * and no other valid return type.
-     *
-     * @expectedException \InvalidArgumentException
-     * @expectedExceptionMessage No valid return type for Magento\Framework\Reflection\Test\Unit\Fixture\TSample::getOnlyNull() specified. Verify the return type and try again.
-     */
-    public function testGetReturnTypeNullAtFirstPosNoValidType()
-    {
-        $classReflection = new ClassReflection(TSample::class);
-        $methodReflection = $classReflection->getMethod('getOnlyNull');
-        $this->typeProcessor->getGetterReturnType($methodReflection);
-    }
-
     /**
      * Simple and complex data provider
      *

diff --git a/lib/internal/Magento/Framework/Reflection/TypeProcessor.php b/lib/internal/Magento/Framework/Reflection/TypeProcessor.php
@@ -293,15 +293,7 @@ public function getGetterReturnType($methodReflection)
                 break;
             }
         }
-        if (!$returnType) {
-            throw new \InvalidArgumentException(
-                sprintf(
-                    'No valid return type for %s::%s() specified. Verify the return type and try again.',
-                    $methodReflection->getDeclaringClass()->getName(),
-                    $methodReflection->getName()
-                )
-            );
-        }
+
         $nullable = in_array('null', $types);
 
         return [