Merge pull request #9076 from magento-gl/spartans_pr_11072024_AC-12119

[Spartans] Bugfix Delivery
magento · Jul 14, 2024 · 29fe909 · 29fe909
2 parents cf65863 + e96ca55
commit 29fe909
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 7 deletions.
diff --git a/app/code/Magento/InstantPurchase/Model/QuoteManagement/QuoteCreation.php b/app/code/Magento/InstantPurchase/Model/QuoteManagement/QuoteCreation.php
@@ -57,9 +57,11 @@ public function createQuote(
         $quote->setCustomer($customer->getDataModel());
         $quote->setCustomerIsGuest(0);
         $quote->getShippingAddress()
-            ->importCustomerAddressData($shippingAddress->getDataModel());
+            ->importCustomerAddressData($shippingAddress->getDataModel())
+            ->setCollectShippingRates(true);
         $quote->getBillingAddress()
-            ->importCustomerAddressData($billingAddress->getDataModel());
+            ->importCustomerAddressData($billingAddress->getDataModel())
+            ->setCollectShippingRates(true);
         $quote->setInventoryProcessed(false);
         return $quote;
     }

diff --git a/...code/Magento/InstantPurchase/Model/ShippingMethodChoose/CheapestMethodDeferredChooser.php b/...code/Magento/InstantPurchase/Model/ShippingMethodChoose/CheapestMethodDeferredChooser.php
@@ -13,17 +13,14 @@
  */
 class CheapestMethodDeferredChooser implements DeferredShippingMethodChooserInterface
 {
-    const METHOD_CODE = 'cheapest';
+    public const METHOD_CODE = 'cheapest';
 
     /**
      * @inheritdoc
      */
     public function choose(Address $address)
     {
-        $address->setCollectShippingRates(true);
-        $address->collectShippingRates();
-        $shippingRates = $address->getAllShippingRates();
-
+        $shippingRates = $this->getShippingRates($address);
         if (empty($shippingRates)) {
             return null;
         }
@@ -32,6 +29,23 @@ public function choose(Address $address)
         return $cheapestRate->getCode();
     }
 
+    /**
+     * Retrieves previously collected shipping rates or computes new ones.
+     *
+     * @param Address $address
+     * @return Rate[]
+     */
+    private function getShippingRates(Address $address) : array
+    {
+        if (!empty($shippingRates = $address->getAllShippingRates())) {
+            // Favour previously collected rates over recomputing.
+            return $shippingRates;
+        }
+        $address->setCollectShippingRates(true);
+        $address->collectShippingRates();
+        return $address->getAllShippingRates();
+    }
+
     /**
      * Selects shipping price with minimal price.
      *