#12061: Cleanup for object manager references and deprecated method

- Updated coding style to match the one used in core magento - Updated integration test to verify for the escaped string
magento · Nov 9, 2017 · 75379cf · 75379cf
1 parent bd8758d
commit 75379cf
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 11 deletions.
diff --git a/app/code/Magento/Contact/Controller/Index/Post.php b/app/code/Magento/Contact/Controller/Index/Post.php
@@ -54,11 +54,10 @@ public function __construct(
         LoggerInterface $logger = null
     ) {
         parent::__construct($context, $contactsConfig);
-        $this->context       = $context;
-        $this->mail          = $mail;
+        $this->context = $context;
+        $this->mail = $mail;
         $this->dataPersistor = $dataPersistor;
-        $this->logger        = $logger ?:
-            ObjectManager::getInstance()->get(LoggerInterface::class);
+        $this->logger = $logger ?: ObjectManager::getInstance()->get(LoggerInterface::class);
     }
 
     /**

diff --git a/app/code/Magento/Contact/Model/Mail.php b/app/code/Magento/Contact/Model/Mail.php
@@ -47,18 +47,17 @@ public function __construct(
         StateInterface $inlineTranslation,
         StoreManagerInterface $storeManager = null
     ) {
-        $this->contactsConfig    = $contactsConfig;
-        $this->transportBuilder  = $transportBuilder;
+        $this->contactsConfig = $contactsConfig;
+        $this->transportBuilder = $transportBuilder;
         $this->inlineTranslation = $inlineTranslation;
-        $this->storeManager      = $storeManager ?:
-            ObjectManager::getInstance()->get(StoreManagerInterface::class);
+        $this->storeManager = $storeManager ?: ObjectManager::getInstance()->get(StoreManagerInterface::class);
     }
 
     /**
      * Send email from contact form
      *
      * @param string $replyTo
-     * @param array  $variables
+     * @param array $variables
      * @return void
      */
     public function send($replyTo, array $variables)
@@ -72,7 +71,7 @@ public function send($replyTo, array $variables)
                 ->setTemplateIdentifier($this->contactsConfig->emailTemplate())
                 ->setTemplateOptions(
                     [
-                        'area'  => Area::AREA_FRONTEND,
+                        'area' => Area::AREA_FRONTEND,
                         'store' => $this->storeManager->getStore()->getId()
                     ]
                 )

diff --git a/dev/tests/integration/testsuite/Magento/Contact/Controller/IndexTest.php b/dev/tests/integration/testsuite/Magento/Contact/Controller/IndexTest.php
@@ -24,7 +24,7 @@ public function testPostAction()
         $this->assertRedirect($this->stringContains('contact/index'));
         $this->assertSessionMessages(
             $this->contains(
-                "Thanks for contacting us with your comments and questions. We'll respond to you very soon."
+                "Thanks for contacting us with your comments and questions. We&#039;ll respond to you very soon."
             ),
             \Magento\Framework\Message\MessageInterface::TYPE_SUCCESS
         );