Skip to content

Commit

Permalink
Merge remote-tracking branch 'upstream/2.2.10-develop' into MC-18478
Browse files Browse the repository at this point in the history
  • Loading branch information
Joan He committed Aug 1, 2019
2 parents 9fcaa74 + 6dd7508 commit 763fd6f
Show file tree
Hide file tree
Showing 6 changed files with 28 additions and 43 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,13 @@ public function getOptions()
\Magento\Eav\Model\ResourceModel\Entity\Attribute\Set\Collection::SORT_ORDER_ASC
);

return $collection->getData();
$collectionData = $collection->getData() ?? [];

array_walk($collectionData, function (&$attribute) {
$attribute['__disableTmpl'] = true;
});

return $collectionData;
}

/**
Expand Down
5 changes: 0 additions & 5 deletions app/code/Magento/Ui/view/base/web/js/grid/editing/record.js
Original file line number Diff line number Diff line change
Expand Up @@ -134,11 +134,6 @@ define([

field = utils.extend({}, fields.base, field);

field.__disableTmpl = {
label: true,
options: true
};

return utils.template(field, {
record: this,
column: column
Expand Down
11 changes: 2 additions & 9 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
"phpseclib/mcrypt_compat": "1.0.8",
"phpseclib/phpseclib": "2.0.*",
"tedivm/jshrink": "~1.3.0",
"magento/composer": "1.2.x-dev as 1.2.1",
"magento/composer": "~1.2.0",
"lib-libxml": "*",
"ext-ctype": "*",
"ext-gd": "*",
Expand Down Expand Up @@ -273,12 +273,5 @@
"Magento\\TestFramework\\Utility\\": "dev/tests/static/framework/Magento/TestFramework/Utility/"
}
},
"prefer-stable": true,
"minimum-stability": "dev",
"repositories": {
"magento.composer": {
"type": "vcs",
"url": "https://github.com/magento/composer.git"
}
}
"minimum-stability": "stable"
}
33 changes: 11 additions & 22 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions lib/internal/Magento/Framework/Filter/Template.php
Original file line number Diff line number Diff line change
Expand Up @@ -72,16 +72,16 @@ class Template implements \Zend_Filter_Interface
'getdatausingmethod',
'__destruct',
'__call',
'__callStatic',
'__callstatic',
'__set',
'__unset',
'__sleep',
'__wakeup',
'__invoke',
'__set_state',
'__debugInfo',
'___callParent',
'___callPlugins'
'__debuginfo',
'___callparent',
'___callplugins'
];

/**
Expand Down
6 changes: 4 additions & 2 deletions lib/web/mage/utils/template.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ define([
* To limit recursion for a specific property add __disableTmpl: {propertyName: numberOfCycles}.
*
* @param {String} tmpl
* @param {Object} target
* @param {Object|undefined} target
* @returns {Boolean|Object}
*/
function isTmplIgnored(tmpl, target) {
Expand Down Expand Up @@ -131,7 +131,9 @@ define([
cycles = 0;

while (~tmpl.indexOf(opener) && (typeof maxCycles === 'undefined' || cycles < maxCycles)) {
tmpl = template(tmpl, data);
if (!isTmplIgnored(tmpl)) {
tmpl = template(tmpl, data);
}

if (tmpl === last) {
break;
Expand Down

0 comments on commit 763fd6f

Please sign in to comment.