Corrected Code Styles

magento · Dec 6, 2019 · b1e518c · b1e518c
1 parent 345ece3
commit b1e518c
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/app/code/Magento/AsynchronousOperations/Model/Operation.php b/app/code/Magento/AsynchronousOperations/Model/Operation.php
@@ -10,7 +10,7 @@
 use Magento\Framework\DataObject;
 
 /**
- * Class Operation
+ * Class Operation encapsulates methods for Operation Model Object
  */
 class Operation extends DataObject implements OperationInterface
 {
@@ -22,12 +22,12 @@ class Operation extends DataObject implements OperationInterface
     /**
      * Operation constructor.
      *
-     * @param array $data
      * @param OperationStatusValidator $operationStatusValidator
+     * @param array $data
      */
     public function __construct(
-        array $data = [],
-        OperationStatusValidator $operationStatusValidator
+        OperationStatusValidator $operationStatusValidator,
+        array $data = []
     ) {
         $this->operationStatusValidator = $operationStatusValidator;
         parent::__construct($data);

diff --git a/app/code/Magento/AsynchronousOperations/Model/OperationStatusValidator.php b/app/code/Magento/AsynchronousOperations/Model/OperationStatusValidator.php
@@ -32,7 +32,9 @@ public function __construct(OperationStatusPool $operationStatusPool)
     /**
      * Validate method
      *
-     * @param $status
+     * @param int $status
+     * @throws \InvalidArgumentException
+     * @return void
      */
     public function validate($status)
     {
@@ -41,7 +43,5 @@ public function validate($status)
         if (!in_array($status, $statuses)) {
             throw new \InvalidArgumentException('Invalid Operation Status.');
         }
-
-        return;
     }
 }
diff --git a/app/code/Magento/AsynchronousOperations/Test/Unit/Model/OperationStatusValidatorTest.php b/app/code/Magento/AsynchronousOperations/Test/Unit/Model/OperationStatusValidatorTest.php
@@ -12,7 +12,7 @@
 use PHPUnit\Framework\TestCase;
 
 /**
- * Class OperationStatusValidatorTest
+ * Class OperationStatusValidatorTest implements logic for testing Operation::setStatus() method
  */
 class OperationStatusValidatorTest extends TestCase
 {
@@ -60,7 +60,7 @@ protected function setUp()
      * @param string $expectedResult
      * @dataProvider dataProviderForTestSetStatus
      */
-    public function testSetStatus (
+    public function testSetStatus(
         string $status,
         array $statusPool,
         string $expectedResult