Skip to content

Commit

Permalink
Implemented code review recommendation
Browse files Browse the repository at this point in the history
  • Loading branch information
ProkopovVitaliy committed Mar 22, 2021
1 parent 3682d87 commit e7b3b4d
Show file tree
Hide file tree
Showing 3 changed files with 35 additions and 6 deletions.
10 changes: 5 additions & 5 deletions app/code/Magento/Msrp/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@ Attribute group - `Advanced Pricing`.
- `msrp` - Manufacturer's Suggested Retail Price
- `msrp_display_actual_price_type` -Display Actual Price

Before disabling or uninstalling this module, note that the following modules depends on this module:

- `Magento_MsrpConfigurableProduct`
- `Magento_MsrpGroupedProduct`
- `Magento_ConfigurableProduct`
**Pay attention** if described attributes not removed when the module is removed/disabled, it would trigger errors
because they use models and blocks from Magento_Msrp module:
- `\Magento\Msrp\Block\Adminhtml\Product\Helper\Form\Type`
- `\Magento\Msrp\Model\Product\Attribute\Source\Type\Price`
- `\Magento\Msrp\Block\Adminhtml\Product\Helper\Form\Type\Price`

For information about a module installation in Magento 2, see [Enable or disable modules](https://devdocs.magento.com/guides/v2.4/install-gde/install/cli/install-cli-subcommands-enable.html).

Expand Down
27 changes: 26 additions & 1 deletion app/code/Magento/Multishipping/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Yo can check this configuration and find more examples in the `etc/frontend/di.x
More information about [type configuration](https://devdocs.magento.com/guides/v2.4/extension-dev-guide/build/di-xml-file.html).


Extension developers can interact with the Magento_Msrp module. For more information about the Magento extension mechanism, see [Magento plug-ins](https://devdocs.magento.com/guides/v2.4/extension-dev-guide/plugins.html).
Extension developers can interact with the Magento_Multishipping module. For more information about the Magento extension mechanism, see [Magento plug-ins](https://devdocs.magento.com/guides/v2.4/extension-dev-guide/plugins.html).

[The Magento dependency injection mechanism](https://devdocs.magento.com/guides/v2.4/extension-dev-guide/depend-inj.html) enables you to override the functionality of the Magento_Msrp module.

Expand All @@ -44,6 +44,31 @@ This module observes the following event:

- `checkout_cart_save_before` in the `Magento\Multishipping\Observer\DisableMultishippingObserver` file.

The module dispatches the following events:

- `multishipping_checkout_controller_success_action` event in the
class `\Magento\Multishipping\Controller\Checkout\Success::execute()` method. Parameters:
- `order_ids` is order ids created during checkout
- `checkout_controller_multishipping_shipping_post` event in the
class `\Magento\Multishipping\Controller\Checkout\ShippingPost::execute()` method. Parameters:
- `request` is a request object `Magento\Framework\App\RequestInterface`.
- `quote` is a quote object for current checkout `Magento\Quote\Model\Quote`.
- `checkout_type_multishipping_set_shipping_items` event in the
class `\Magento\Multishipping\Model\Checkout\Type\Multishipping::setShippingItemsInformation()` method. Parameters:
- `quote` is a quote object for current checkout `Magento\Quote\Model\Quote`.
- `checkout_type_multishipping_create_orders_single` event in the
class `\Magento\Multishipping\Model\Checkout\Type\Multishipping::createOrders()` method. Parameters:
- `order` is a prepared order object for creating `\Magento\Sales\Model\Order`.
- `address` is an address array.
- `quote` is a quote object for current checkout `Magento\Quote\Model\Quote`.
- `checkout_submit_all_after` event in the
class `\Magento\Multishipping\Model\Checkout\Type\Multishipping::createOrders()` method. Parameters:
- `orders` is order object array `\Magento\Sales\Model\Order` that was created.
- `quote` is a quote object for current checkout `Magento\Quote\Model\Quote`.
- `checkout_multishipping_refund_all` event in the
class `\Magento\Multishipping\Model\Checkout\Type\Multishipping::createOrders()` method. Parameters:
- `orders` is order object array `\Magento\Sales\Model\Order` that was created.

For information about an event in Magento 2, see [Events and observers](http://devdocs.magento.com/guides/v2.3/extension-dev-guide/events-and-observers.html#events).

### Layouts
Expand Down
4 changes: 4 additions & 0 deletions app/code/Magento/MysqlMq/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

**Magento_MysqlMq** provides message queue implementation based on MySQL.

Module contain recurring script, declared in `Magento\MysqlMq\Setup\Recurring`
class. This script is executed by Magento post each schema installation or upgrade
stage and populates the queue table.

## Installation

Module creates the following tables:
Expand Down

0 comments on commit e7b3b4d

Please sign in to comment.