Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Database Schema: Missing important Foreign Keys #1001

Closed
SchumacherFM opened this issue Jan 27, 2015 · 3 comments
Closed

Database Schema: Missing important Foreign Keys #1001

SchumacherFM opened this issue Jan 27, 2015 · 3 comments

Comments

@SchumacherFM
Copy link
Member

During my database schema comparison I discovered several missing foreign keys and one incorrect unique index (at least I think the unique key is wrong 8-) Issue #1002 ).

The following 5 screenshots shows the missing keys. Left side Magento2 and right side Magento1.

If there is a technical reason why you haven't implemented the keys: Please explain :-)

catalog_product_index_eav_decimal
catalog_product_index_eav
cataloginventory_stock_status
catalogrule_product_1
catalogrule_product_price_1
@SchumacherFM SchumacherFM changed the title Database Schema: Missing important Foreign Keys and incorrect Unique Indexes Database Schema: Missing important Foreign Keys Jan 27, 2015
@orlangur
Copy link
Contributor

Few of keys you mentioned were identified as unused with http://www.percona.com/doc/percona-toolkit/2.1/pt-duplicate-key-checker.html and thus eliminated.

@kokoc
Copy link
Member

kokoc commented Feb 3, 2015

@SchumacherFM There are two main reasons why we removed such keys:

  • @orlangur mentioned the first one
  • We removed some foreign keys from index tables in order to speed up insert/update operations. Consistency is guaranteed by application.

Do you have any additional questions?

@SchumacherFM
Copy link
Member Author

Thank you for answering!

magento-engcom-team added a commit that referenced this issue Oct 22, 2019
@magento-engcom-team
ENGCOM-6062: Cover exceptions in \Magento\CustomerGraphQl\Model\Resol…
fc53cf2 
…ver\CreateCustomerAddress #1001

 - Merge Pull Request magento/graphql-ce#1001 from TomashKhamlai/graphql-ce:coverage-create-customer-address-input
 - Merged commits:
   1. f1e8568
magento-engcom-team pushed a commit that referenced this issue Oct 22, 2019
@lenaorobei
ENGCOM-6062: Cover exceptions in \Magento\CustomerGraphQl\Model\Resol…
d03e320 
…ver\CreateCustomerAddress #1001
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@SchumacherFM @orlangur @kokoc @vpelipenko