Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support of federal units of Brazil with 27 states #115

Closed
hackin88 opened this issue Nov 5, 2012 · 4 comments
Closed

support of federal units of Brazil with 27 states #115

hackin88 opened this issue Nov 5, 2012 · 4 comments

Comments

@hackin88
Copy link

hackin88 commented Nov 5, 2012

I see that in the native Magento2 is already pt_BR translation package, this was a breakthrough for users of magento in Brazil

I see that the support of the federal units of Brazil is not yet supported for Brazil, it would be very important if Magento2 added to support the 27 federal units of Brazil

Nowadays the form used to apply the support of the federal units of Brazil is done manually as shown below, and is usually done in the wrong way, because the need to implement proper support manual

http://www.cerebrum.com.br/forum/index.php?/topic/196-adicionando-os-estados-brasileiros-no-magento/

http://pt.wikipedia.org/wiki/Unidades_federativas_do_Brasil

@magento-team
Copy link
Contributor

Hello. Would you be able to provide this as a code contribution (pull request)? Then we could easily incorporate it into Magento 2.

@hackin88
Copy link
Author

hackin88 commented Nov 8, 2012

For my account is not showing the ability to send requests

I accessed my account and clicked on the button "FORK"

Still on Github edited the following file in my project Magento2

/app/code/core/Mage/Directory/data/directory_setup/data-install-1.6.0.0.php

I Added below line 286 the following script

,array('BR', 'AC', 'Acre'),
array('BR', 'AL', 'Alagoas'),
array('BR', 'AP', 'Amapá'),
array('BR', 'AM', 'Amazonas'),
array('BR', 'BA', 'Bahia'),
array('BR', 'CE', 'Ceará'),
array('BR', 'ES', 'Espírito Santo'),
array('BR', 'GO', 'Goiás'),
array('BR', 'MA', 'Maranhão'),
array('BR', 'MT', 'Mato Grosso'),
array('BR', 'MS', 'Mato Grosso do Sul'),
array('BR', 'MG', 'Minas Gerais'),
array('BR', 'PA', 'Pará'),
array('BR', 'PB', 'Paraíba'),
array('BR', 'PR', 'Paraná'),
array('BR', 'PE', 'Pernambuco'),
array('BR', 'PI', 'Piauí'),
array('BR', 'RJ', 'Rio de Janeiro'),
array('BR', 'RN', 'Rio Grande do Norte'),
array('BR', 'RS', 'Rio Grande do Sul'),
array('BR', 'RO', 'Rondônia'),
array('BR', 'RR', 'Roraima'),
array('BR', 'SC', 'Santa Catarina'),
array('BR', 'SP', 'São Paulo'),
array('BR', 'SE', 'Sergipe'),
array('BR', 'TO', 'Tocantins'),
array('BR', 'DF', 'Distrito Federal')

Thus when installing Magento it should come with support for 27 states of Brazil

https://github.com/hackin88/magento2/blob/master/app/code/core/Mage/Directory/data/directory_setup/data-install-1.6.0.0.php

This is the first time that I move to Github is the correct procedure I'm doing to contribute to the Magento2?

@hackin88
Copy link
Author

hackin88 commented Nov 8, 2012

Now i clicked in button "PULL Request"

I added a Title and "Send Pull Request"

Now the information is displayed in

https://github.com/magento/magento2/pulls

@magento-team
Copy link
Contributor

Hi. I will close this thread and use the pull request. I believe it should not be put in a modified existing installation file but created as a new data/update script - however we will try to take it from the pull request and change it so it is correct. Thanks for the contribution.

vpelipenko pushed a commit to vpelipenko/magento2 that referenced this issue Mar 5, 2015
[Folks] M2 GitHub Update (version 0.42.0-beta10)
okorshenko pushed a commit that referenced this issue Jun 16, 2016
VitaliyBoyko pushed a commit to VitaliyBoyko/magento2 that referenced this issue Nov 25, 2017
VitaliyBoyko pushed a commit to VitaliyBoyko/magento2 that referenced this issue Nov 25, 2017
- Add Documentation
- phpcs fixes
- Impelement phpunit test for ValidatorChain
magento-engcom-team pushed a commit that referenced this issue Apr 13, 2018
…-dependency

94: Remove Zend_Service Dependency from CurrencyInterface
magento-engcom-team added a commit that referenced this issue Jul 21, 2018
…essage improvements #115

 - Merge Pull Request magento-engcom/import-export-improvements#115 from tadhgbowe/import-export-improvements:import-export-issue-82-error-messaging
 - Merged commits:
   1. e99c99e
   2. 65bce0a
   3. 7f9f6db
   4. a76e3a3
   5. 3a0599d
   6. 6a5b15d
   7. b98f417
   8. 8db836b
magento-engcom-team pushed a commit that referenced this issue Jul 21, 2018
magento-engcom-team pushed a commit to okorshenko/magento2 that referenced this issue May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants