Old price excluding TAX is incorrectly replaced by JavaScript

[VesnaS]

Preconditions

1. Tested on Magento versions 2.4-develop
2. PHP 7.2

Steps to reproduce

1. In Admin, set Stores -> Configuration -> SALES -> Tax -> Price Display Settings -> Display Product Prices In Catalog to "Including and Excluding Tax"
2. Configure tax class and set it for the product
3. Set special price for the product
4. In vendor/magento/module-catalog/view/base/templates/product/price/final_price.phtml, set "skip_adjustments" to FALSE for "old-price"

Expected result

1. On product detail view page in frontend, old price and new price are displayed with and without TAX

Actual result

1. New price and old price excluding TAX are the same. This happens because JavaScript in vendor/magento/module-catalog/view/base/web/js/price-box.js replaces prices incorrectly.

[magento-engcom-team]

@VesnaS, thank you for your report.
We've created internal ticket(s) MAGETWO-83250 to track progress on the issue.

[joachimVT]

I can confirm this having the same issue on version 2.2.2

[MaximilianSchwarz]

I have the same issue in Magento 2.2.2. Is there any new information about this bug?

[HashDefineElectronics]

Hi All,

My Issue

When the store is configure to allow both Include and Exclude tax to be display on the product page then the following happens to me.

On products with special price enabled, The
special price value for excluding tax will be set to Old price excluding tax.
This is because the Excluding tax html element for Special price and Old price using the same price type. This means that price-box.js is unable to differentiate between prices when it loads.

Ideally, which ever code set the data-price-type for each of these element should also make sure that it take into account that when both tax types are displayed.

The quick solution

My quick fix is to override the data-price-type value before price-box.js store the price options.

Steps

• First copy MAGE_ROOT/app/code/Magento/Catalog/view/base/web/js/price-box.js to your theme or module. (ie MAGE_ROOT/app/design/frontend/VENDOR/YOUR_THEME/Magento_Catalog/web/js/my-price-box.js
• update the requirejs-config.js from your module: (*MAGE_ROOT/app/design/frontend/VENDOR/YOUR_THEME/Magento_Catalog/requirejs-config.js)

var config = {
    map: {
        '*': {
               priceBox:'Magento_Catalog/js/my-price-box',
        }
   }
};

• Insert the following code into function _setDefaultsFromDataSet after line 191 in marv-price-box.js.

label = $(element).data('label')
if(type && label) {
    type += label;
}

It should look like this:

        /**
         * setDefaultsFromDataSet
         */
        _setDefaultsFromDataSet: function _setDefaultsFromDataSet() {
            var box = this.element,
                priceHolders = $('[data-price-type]', box),
                prices = this.options.prices;

            this.options.productId = box.data('productId');

            if (_.isEmpty(prices)) {
                priceHolders.each(function (index, element) {
                    var type = $(element).data('priceType'),
                        label = $(element).data('label'),
                        amount = parseFloat($(element).data('priceAmount'));

                    $(element).data('priceType', type + label)

                    if(type && label) {
                       type += label;
                    }

                    if (type && !_.isNaN(amount)) {
                        prices[type] = {
                            amount: amount
                        };
                    }
                });
            }
        },

[malikt]

Any solution to this issue?

[malikt]

i was able to do a quick fix for it, but it will be a good to have a better and permanent solution by the team.

[DanielRuf]

i was able to do a quick fix for it

Can you show it for us?

[duckchip]

@magento-engcom-team Any news on this issue?

[melaniajitaru]

Hi,

This error also appears in Magento 2.3.3. Do you have any news on how to fix it? @magento-engcom-team

Thanks.

[m2-assistant]

Hi @engcom-Alfa. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

• 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 2. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 3. If the issue is not relevant or is not reproducible any more, feel free to close it.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[Krielkip]

@LeanderFS nice found 👍 (I haven't used tier prices for this use case)

[engcom-Lima]

Hi @VesnaS,

Thank you for reporting the issue.

I have tried this issue on the fresh installation Magento 2.4-dev but I am not able to reproduce it.
Steps followed to reproduce the issue:

1. In Admin, set Stores -> Configuration -> SALES -> Tax -> Price Display Settings -> Display Product Prices In Catalog to "Including and Excluding Tax"
2. Configure tax class and set it for the product
3. Set special price for the product
4. In vendor/magento/module-catalog/view/base/templates/product/price/final_price.phtml, set "skip_adjustments" to FALSE for "old-price"

Output: On product detail view page in frontend, old price and new price are displayed with and without TAX

Kindly recheck the issue on Magento 2.4-develop branch and elaborate the steps if the issue is still reproducible.
Thank you.

[Krielkip]

22 days ago

Hi @engcom-Lima ,
You need to follow the actions told by @LeanderFS .
See reply:
#11998 (comment)

[m2-assistant]

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Bravo]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @engcom-Bravo, here is your Magento Instance: https://27ddafc57269735f3cb5f1f8e086cfb2.instances.magento-community.engineering
Admin access: https://27ddafc57269735f3cb5f1f8e086cfb2.instances.magento-community.engineering/admin_c22d
Login: f34d3867
Password: fbe467767283

[engcom-Bravo]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @engcom-Bravo, here is your Magento Instance: https://27ddafc57269735f3cb5f1f8e086cfb2.instances.magento-community.engineering
Admin access: https://27ddafc57269735f3cb5f1f8e086cfb2.instances.magento-community.engineering/admin_f7ed
Login: e99e4a9b
Password: 54c4cc395c52

[engcom-Bravo]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @engcom-Bravo, here is your Magento Instance: https://27ddafc57269735f3cb5f1f8e086cfb2.instances.magento-community.engineering
Admin access: https://27ddafc57269735f3cb5f1f8e086cfb2.instances.magento-community.engineering/admin_1a2e
Login: 99e600d6
Password: 628a85e578ab

[engcom-Bravo]

Hi @VesnaS

Thank you for reporting and collaboration.
Verified the issue on Magento 2.4-develop branch but could not able to reproduce the issue.
Followed above comment

Kindly refer this video,If I am missing anything steps please provide information.
Please try to check in latest 2.4 develop branch with Php 8.1.

Thanks.

[engcom-Bravo]

Hi @VesnaS,

We have noticed that this issue has not been updated for a period of 14 Days.
Hence we assume that this issue is fixed now, so we are closing it. Please raise a fresh ticket or reopen this ticket if you need more assistance on this.

Thanks.