-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QuoteRepository get methods won't return CartInterface but Quote model #12802
Comments
Any updates on this one? |
@msieprawski, thank you for your report. |
So... ? |
Hi @Bartlomiejsz. Thank you for working on this issue.
|
…Api\Data\CartInterface and return correct object from QuoteRepository (+4 squashed commits) Squashed commits: [55b9f3ec52b] Fix magento#12802 - fix phpmd, mark quoteFactory as deprecated [56ca9a42468] Fix magento#12802 - change condition in quoteRepository [734212812a4] Fix magento#12802 - revert change of constructor parameters names [ba8ad543e0f] Fix magento#12802 - remove instanceof condition
Hi @msieprawski. Thank you for your report.
The fix will be available with the upcoming 2.3.2 release. |
…face and return correct object from QuoteRepository #22149
…Api\Data\CartInterface and return correct object from QuoteRepository (+4 squashed commits) Squashed commits: [55b9f3ec52b] Fix magento#12802 - fix phpmd, mark quoteFactory as deprecated [56ca9a42468] Fix magento#12802 - change condition in quoteRepository [734212812a4] Fix magento#12802 - revert change of constructor parameters names [ba8ad543e0f] Fix magento#12802 - remove instanceof condition
…Api\Data\CartInterface and return correct object from QuoteRepository (+4 squashed commits) Squashed commits: [55b9f3ec52b] Fix magento#12802 - fix phpmd, mark quoteFactory as deprecated [56ca9a42468] Fix magento#12802 - change condition in quoteRepository [734212812a4] Fix magento#12802 - revert change of constructor parameters names [ba8ad543e0f] Fix magento#12802 - remove instanceof condition
Hi @msieprawski. Thank you for your report. The fix will be available with the upcoming 2.2.10 release. |
…r CartInterface and return correct object from QuoteRepository #22549
Preconditions
Steps to reproduce
\Vendor\Module\Model\Quote
object which extends\Magento\Quote\Model\Quote
.Expected result
Vendor\Module\Model\Quote
Actual result
Magento\Quote\Model\Quote
It's caused by invalid vendor/magento/module-quote/Model/QuoteRepository.php::loadQuote method which uses
Magento\Quote\Model\QuoteFactory
in the very first line instead ofMagento\Quote\Api\Data\CartInterfaceFactory
.The solution is to override QuoteRepository's loadQuote method and use CartInterfaceFactory.
The text was updated successfully, but these errors were encountered: