Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magento 2 Bin directory #1429

Closed
jamescowie opened this issue Jun 30, 2015 · 5 comments
Closed

Magento 2 Bin directory #1429

jamescowie opened this issue Jun 30, 2015 · 5 comments
Labels
Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@jamescowie
Copy link

So magento now has a bin directory where the new and great magento command can be found.
However it is a common configuration option for projects to also use bin for composer binaries that are available. E.g. Behat, PHPSpec, PHPUnit etc.

Because in the package magento2-base there is the mapping information for:

            [
                "bin",
                "bin"
            ],

When the composer and the hackathon installer process run after an update / install then the project roots bin directory is cleared out and only the magento 2 directory is created. This causes problems for projects that are configured to run the binaries from ./bin. Granted the binaries are still available from ./vendor/package/bin/package however it would be ideal to remove the mapping from magento2-base and replace with the following configuration in composer.json

"bin": ["bin/magento”]

This would mean that composer can place the magento command into the projects configured bin directory offering a single configuration node for the bin folder that is managed via composer and magento

What do you think ?

This relates to MAGETWO-38518 and #1351 but contains more information on what is causing the replacement.

@buskamuza
Copy link
Contributor

@jamescowie , we're currently working on this fix (MAGETWO-38518) and you described exactly what we're going to change. So, I believe, we should cover the case you describe.
The fix should be available soon, but depending on the publication to this repository and other internal procedures it may take couple weeks.

@vancoz
Copy link

vancoz commented Jul 2, 2015

Also looks like we have reported duplicate issue #1351

@vpelipenko vpelipenko added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jul 2, 2015
@jamescowie
Copy link
Author

Hi @vancoz yep this is a reported issue of the other ticket I raised. Happy to close this or the other. Reason for a new ticket was to provide more info on a single issue that was not git workflow :)

While continuing my work on M2 and related to this issue one really annoying thing other than getting my bin dir wiped out each update is that it seems that the permissions for bin/magento are changed on each release of the beta. I found that the permissions are not executable when I clone down.. Is this intentional ?

@vancoz
Copy link

vancoz commented Jul 6, 2015

@jamescowie thank you for detailed description, bug already fixed and right now we are working on contribution.

Regarding question about permissions - it is not intentional.

@piotrekkaminski
Copy link
Contributor

It should not be replaced anymore so closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

5 participants