Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bookmark views become uneditable after deleting the first bookmark view. #14913

Closed
Jakhotiya opened this issue Apr 30, 2018 · 6 comments
Closed

bookmark views become uneditable after deleting the first bookmark view. #14913

Jakhotiya opened this issue Apr 30, 2018 · 6 comments
Assignees
@Bartlomiejsz
Labels
Component: Catalog Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@Jakhotiya
Copy link
Contributor

Jakhotiya commented Apr 30, 2018 •
edited by engcom-Bravo
Loading

For product listing grid, I created multiple bookmark views like in following screenshot. When **I delete the first view I created ** all other views become uneditable except the last view.

screen shot 2018-04-30 at 2 59 47 pm

screen shot 2018-04-30 at 3 00 14 pm

The highlighted view in screeshot has become uneditable. If I don't delete the first view then they all remain editable.

Preconditions

  1. Magento 2.2.3 or 2.2-develop branch Updated(09/25/2019): Still actual on 2.3-develop
  2. Chrome 65 (That's what I have)

Steps to reproduce

  1. Login to admin and go to Catalog->Products. You should see product grid
  2. Change the sorting order of columns and save this new view. In similar way by adding filters or adding new columns create multiple bookmark views. I created atleast 8 of them.
  3. Now refresh the page. Switch back to default view in bookmarks.
  4. Delete the first bookmark you created
  5. Try editing any other bookmark except last one.

Expected result

  1. All the bookmarks should be editable

Actual result

  1. Only last one is editable.
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Apr 30, 2018
@ghost ghost self-assigned this Jul 12, 2018
@ghost ghost added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Jul 12, 2018
@ghost
Copy link

ghost commented Jul 12, 2018 •
edited by ghost
Loading

Hi @Jakhotiya thank you for your report.
We've acknowledged the issue and added to our backlog.

@ghost ghost added the Component: Catalog label Jul 12, 2018
@ghost ghost removed their assignment Jul 12, 2018
@nirav-kadiya nirav-kadiya self-assigned this Nov 3, 2018
@magento-engcom-team
Copy link
Contributor

Hi @ssp58bleuciel. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@engcom-Bravo engcom-Bravo self-assigned this Sep 23, 2019
@m2-assistant
Copy link

m2-assistant bot commented Sep 23, 2019

Hi @engcom-Bravo. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.

@engcom-Bravo engcom-Bravo removed their assignment Sep 23, 2019
@sergiy-v sergiy-v self-assigned this Sep 27, 2019
@m2-assistant
Copy link

m2-assistant bot commented Sep 27, 2019

Hi @sergiy-v. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.

@ghost ghost unassigned sergiy-v Oct 22, 2019
@Bartlomiejsz Bartlomiejsz self-assigned this Jan 4, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jan 4, 2020

Hi @Bartlomiejsz. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.

Bartlomiejsz added a commit to Bartlomiejsz/magento2 that referenced this issue Jan 4, 2020
@Bartlomiejsz
Fix magento#14913 - bookmark views become uneditable after deleting t…
fe98438 
…he first bookmark view
@Bartlomiejsz Bartlomiejsz mentioned this issue Jan 4, 2020
Merged
4 tasks
@Bartlomiejsz Bartlomiejsz added the Progress: PR Created Indicates that Pull Request has been created to fix issue label Jan 5, 2020
@VladimirZaets
Copy link
Contributor

Hi @Jakhotiya. Thank you for your report.
The issue has been fixed in #26263 by @Bartlomiejsz in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.0 release.

@VladimirZaets VladimirZaets added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Jan 9, 2020
magento-engcom-team added a commit that referenced this issue Jan 9, 2020
@magento-engcom-team
ENGCOM-6546: Fix #14913 - bookmark views become uneditable after dele…
e38e43d 
…ting the first bookmark view #26263

 - Merge Pull Request #26263 from Bartlomiejsz/magento2:feature/fix_14913_bookmarks_uneditable
 - Merged commits:
   1. fe98438
magento-engcom-team pushed a commit that referenced this issue Jan 9, 2020
@VladimirZaets
ENGCOM-6546: Fix #14913 - bookmark views become uneditable after dele…
537344e 
…ting the first bookmark view #26263
@sdzhepa sdzhepa mentioned this issue May 9, 2022
Open
@sdzhepa sdzhepa mentioned this issue May 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bartlomiejsz Bartlomiejsz

Labels
Component: Catalog Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@sergiy-v @VladimirZaets @Jakhotiya @Bartlomiejsz @magento-engcom-team @nirav-kadiya @engcom-Bravo