-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkout/Model/Session doesn't set the $quoteIdMask #1631
Comments
Hi @daancart2quote, there is a long discussion about naming convention here #935. We don't have strict rules how method should be named, only recommendations. In this case, I think, it is OK to use name 'isQuoteMasked', look at the latest @TexanHogman comment. |
Hello @vpelipenko, The issue is not the naming, the issue is that So to follow the example of @TexanHogman, the way to solve this is to add the following function:
|
Probably, I missed something... but isQuoteMasked method exists in this class https://github.com/magento/magento2/blob/develop/app/code/Magento/Checkout/Model/Session.php#L504 |
It looks like my beta was just a version older... Sorry! |
[Helix] Update Changelog based on delivered scope
In the file
magento2/app/code/Magento/Checkout/Model/Session.php
on line256
there seem to be a small error.$this->isQuoteMasked()
us used to get thebool $isQuoteMasked
but that should be$this->getIsQuoteMasked()
or$this->isQuoteMasked
The text was updated successfully, but these errors were encountered: