Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Currency sign for "Layered Navigation Price Step" is not according to default settings #21684

Closed
dmak opened this issue Mar 11, 2019 · 21 comments
Closed

Currency sign for "Layered Navigation Price Step" is not according to default settings #21684

dmak opened this issue Mar 11, 2019 · 21 comments
Assignees
@edenduong @Bartlomiejsz
Labels
Component: CurrencySymbol Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@dmak
Copy link

dmak commented Mar 11, 2019 •
edited by hiren0241
Loading

Preconditions (*)

  1. Magento CE 2.7 or 2.3
  2. Please set Base Currency = Euro
  3. Please set Default Currency = Euro
  4. Please set Allow Currency = Euro

Steps to reproduce (*)

  1. Go to catalog --> Categories --> Add Sub Category
  2. Expand Display Settings
  3. Check currency symbol in Layered Navigation Price Step

Expected result (*)

With these settings the currency displayed in Layered Navigation Price Step must be euro sign (€).

Actual result (*)

With these settings the currency displayed in Layered Navigation Price Step is incorrect: displays dollar sign ($), but expected euro sign (€):
image

Note (*)

currency displayed in product (Price, Customizable Options → Option → Price) are correct.
@magento-engcom-team
Copy link
Contributor

Hi @dmak. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@dmak do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Mar 11, 2019
@hiren0241
Copy link
Contributor

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @hiren0241. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@hiren0241 hiren0241 self-assigned this Mar 11, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Mar 11, 2019 •
edited by hiren0241
Loading

Hi @hiren0241. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • Next steps are available in case you are a member of Community Maintainers.

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@magento-engcom-team
Copy link
Contributor

Hi @hiren0241, here is your Magento instance.
Admin access: https://i-21684-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Mar 11, 2019
@hiren0241 hiren0241 added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Mar 11, 2019
@magento-engcom-team
Copy link
Contributor

@hiren0241 Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

  • Add "Component: " label(s) to this ticket based on verification result. If uncertain, you may follow the best guess

Once all required information is added, please add label "Issue: Confirmed" again.
Thanks!

@magento-engcom-team magento-engcom-team removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Mar 11, 2019
@hiren0241 hiren0241 added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Component: CurrencySymbol labels Mar 11, 2019
@magento-engcom-team magento-engcom-team removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Mar 11, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @hiren0241
Thank you for verifying the issue! 👍 Your confirmation will help us to acknowledge and process this report.

@hiren0241
Copy link
Contributor

@magento-engcom-team give me 2.2-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @hiren0241. Thank you for your request. I'm working on Magento 2.2-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @hiren0241, here is your Magento instance.
Admin access: https://i-21684-2-2-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@hiren0241 hiren0241 added the Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release label Mar 11, 2019
@hiren0241 hiren0241 self-assigned this Mar 11, 2019
@magento-engcom-team
Copy link
Contributor

Hi @hiren0241. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • Next steps are available in case you are a member of Community Maintainers.

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@shikhamis11 shikhamis11 self-assigned this Mar 29, 2019
@shikhamis11
Copy link
Member

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11, here is your Magento instance.
Admin access: https://i-21684-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@shikhamis11 shikhamis11 added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Mar 29, 2019
@ghost ghost assigned shikhamis11 Apr 10, 2019
@Shubham0492
Copy link

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @Shubham-Webkul. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @Shubham-Webkul, here is your Magento instance.
Admin access: https://i-21684-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@Shubham0492 Shubham0492 self-assigned this May 4, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 4, 2019

Hi @Shubham-Webkul. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@Shubham0492
Copy link

reproducible on 2.3-develop

@ghost ghost unassigned shikhamis11 Jun 25, 2019
@ghost ghost unassigned Shubham0492 and hiren0241 Sep 27, 2019
@Bartlomiejsz Bartlomiejsz mentioned this issue Oct 1, 2019
Merged
4 tasks
@ghost ghost assigned Bartlomiejsz Oct 1, 2019
@Bartlomiejsz Bartlomiejsz added the Progress: PR Created Indicates that Pull Request has been created to fix issue label Nov 19, 2019
Bartlomiejsz added a commit to Bartlomiejsz/magento2 that referenced this issue Dec 9, 2019
@Bartlomiejsz
Fix magento#21684 - Currency sign for "Layered Navigation Price Step"…
2c70512 
… is not according to default settings
Bartlomiejsz added a commit to Bartlomiejsz/magento2 that referenced this issue Dec 9, 2019
@Bartlomiejsz
Fix magento#21684 - fix class imported
2a5c87c
Bartlomiejsz added a commit to Bartlomiejsz/magento2 that referenced this issue Dec 9, 2019
@Bartlomiejsz
Fix magento#21684 - code style fix
9c4c965
@Bartlomiejsz Bartlomiejsz mentioned this issue Dec 10, 2019
Closed
@edenduong edenduong mentioned this issue Dec 10, 2019
Closed
4 tasks
@ghost ghost assigned edenduong Dec 10, 2019
@VladimirZaets VladimirZaets added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Jan 8, 2020
@VladimirZaets
Copy link
Contributor

Hi @dmak. Thank you for your report.
The issue has been fixed in #24815 by @Bartlomiejsz in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.0 release.

magento-engcom-team added a commit that referenced this issue Jan 8, 2020
@magento-engcom-team
ENGCOM-5986: Fix #21684 - Currency sign for 'Layered Navigation Price…
3812c32 
… Step' is not according to default settings #24815

 - Merge Pull Request #24815 from Bartlomiejsz/magento2:feature/fix_21684_currency_sign_layered_navigation_price_step
 - Merged commits:
   1. 2c70512
   2. 2a5c87c
   3. d351549
   4. 9c4c965
magento-engcom-team pushed a commit that referenced this issue Jan 8, 2020
@VladimirZaets
ENGCOM-5986: Fix #21684 - Currency sign for "Layered Navigation Price…
a12b93b 
… Step" is not according to default settings #24815
This was referenced May 9, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edenduong edenduong

@Bartlomiejsz Bartlomiejsz

Labels
Component: CurrencySymbol Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
8 participants
@dmak @VladimirZaets @edenduong @Bartlomiejsz @shikhamis11 @magento-engcom-team @Shubham0492 @hiren0241