Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

22010 -Updates AbstractExtensibleObject and AbstractExtensibleModel annotations #22010

Closed
atwixfirster opened this issue Mar 28, 2019 · 2 comments
Closed

22010 -Updates AbstractExtensibleObject and AbstractExtensibleModel annotations #22010

atwixfirster opened this issue Mar 28, 2019 · 2 comments
Assignees
@atwixfirster
Labels
Component: Framework/Api USE ONLY for FRAMEWORK RELATED BUG! E.g If bug related to Catalog Service Contracts use just Catalog Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Partner: Atwix Pull Request is created by partner Atwix Release Line: 2.3 Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@atwixfirster
Copy link
Contributor

atwixfirster commented Mar 28, 2019 •
edited by ghost
Loading

Preconditions (*)

  1. Magento 2.3.1

Summary (*)

Magento is no longer support inheritance of DTO classes from Magento\Framework\Api\AbstractExtensibleObject. This class extends abstract class AbstractExtensibleObject extends AbstractSimpleObject. There is a new code and new modules, for example, Inventory module which uses inheritance of Magento\Framework\Model\AbstractExtensibleModel.

Examples (*)

The misunderstanding is caused a point that AbstractExtensibleObject class marked as @api, in the sime time AbstractExtensibleModel does not have the same mark.

Proposed solution

  • Add PHP annotation @api to AbstractExtensibleModel
  • Add PHP annotation @deprecated to AbstractExtensibleObject and @see which link to AbstractExtensibleModel

CC: @maghamed

22010

Thank you! 😊
@magento-engcom-team
Copy link
Contributor

Hi @atwixfirster. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@atwixfirster do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Mar 28, 2019
@atwixfirster atwixfirster self-assigned this Mar 28, 2019
@atwixfirster atwixfirster changed the title Magento 2.3.1 22010 -Updates AbstractExtensibleObject and AbstractExtensibleModel annotations Mar 28, 2019
atwixfirster added a commit that referenced this issue Mar 28, 2019
@atwixfirster
#22010: Updates AbstractExtensibleObject and AbstractExtensibleModel …
1a2b1ce 
…annotations
@atwixfirster atwixfirster mentioned this issue Mar 28, 2019
Merged
@atwixfirster atwixfirster added Partner: Atwix Pull Request is created by partner Atwix Release Line: 2.3 labels Mar 28, 2019
@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Mar 28, 2019
@ghost ghost added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Mar 28, 2019
@shikhamis11 shikhamis11 added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Component: Framework/Api USE ONLY for FRAMEWORK RELATED BUG! E.g If bug related to Catalog Service Contracts use just Catalog labels Mar 29, 2019
@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Mar 25, 2020
@magento-engcom-team
Copy link
Contributor

Hi @atwixfirster. Thank you for your report.
The issue has been fixed in #22011 by @atwixfirster in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.0 release.

@ghost ghost added Progress: done and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Mar 25, 2020
This was referenced May 9, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atwixfirster atwixfirster

Labels
Component: Framework/Api USE ONLY for FRAMEWORK RELATED BUG! E.g If bug related to Catalog Service Contracts use just Catalog Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Partner: Atwix Pull Request is created by partner Atwix Release Line: 2.3 Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@atwixfirster @shikhamis11 @magento-engcom-team