Unable to save any dates if the user interface locale is not english (US) in 2.3.1 #22964

ioweb-gr · 2019-05-21T19:56:33Z

Preconditions (*)

Magento 2.3.1
A user with interface locale set to Greek

Steps to reproduce (*)

Create a product using the user that has interface locale set to Greek.
Add any date value, news_from_date, news_to_date, special_price_from_date, special_price_to_date
Save the product

Expected result (*)

The product is saved correctly with the new date.

Actual result (*)

Error that says invalid date Invalid input datetime format of value '22/5/2019'

I've found other references in other issues that are closed saying this problem was fixed but unfortunately I'm on 2.3.1 and the issue persists. There's no real solution or workaround yet for this. Apparently it's not just Greek locale but other locales as well.

The bug has been acknowledged in the past, added to backlog even but years later we still face the same issue from version 2.1 to 2.3.1

Unless Magento is operating in a country where the users speak english natively it's pretty much pointless to use Magento if this is not fixed. I opened a new issue for this because any messages in closed issues get burried and never watched upon.

I'm hoping someone who understands the inner workings of this date format validation will pay attention to this or else the biggest question we'll have to ask any potential customer before choosing a platform will pretty much be: "Are you fluent in English?"

PS: at least if you could provide an official way to workaround this or what to change until it's fixed it would be completely fine so we can at least use the platform.

m2-assistant · 2019-05-21T19:56:35Z

Hi @ioweb-gr. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

Summary of the issue
Information on your environment
Steps to reproduce
Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@ioweb-gr do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

yes
no

Join Magento Community Engineering Slack and ask your questions in #github channel.

ioweb-gr · 2019-05-21T19:56:59Z

@magento-engcom-team give me 2.3-develop instance

magento-engcom-team · 2019-05-21T19:57:02Z

Hi @ioweb-gr. Thank you for your request. I'm working on Magento 2.3-develop instance for you

magento-engcom-team · 2019-05-21T19:58:00Z

Hi @ioweb-gr, here is your Magento instance.
Admin access: https://i-22964-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

ioweb-gr · 2019-05-21T20:03:01Z

Reproduced on demo instance.

orlangur · 2019-05-22T00:01:52Z

@ioweb-gr it's better to search for closed issues and reopen them to track regressions better.

#9743 seems one of those, is it reproducible again? Is this issue introduced by 2.3.1 and not present in 2.3.0?

ioweb-gr · 2019-05-22T03:27:10Z

@orlangur For me it was never fixed in the first place. I can't seem to be able to track this issue that made me open a new one now, but it was a closed ticket with a few replies spaning over a year that the issue still persists.

I mean if noone reopened that ticket after a year or so, I kinda gave up on reopening closed issues.
Also I've tried to comment on a newer one #13112 which was for 2.2 version but it seems it was ignored as well for quite some time (from Jan 18).

It seems closed issues and old issues are never paid any attention to. You're right that it helps if it's reopened and worked on again, but it doesn't help if no one sees it.

orlangur · 2019-05-22T08:04:12Z

It seems closed issues and old issues are never paid any attention to

@ioweb-gr well, it is simply impossible, unless anybody finds such issue and reopens it or if we have a proper end-to-end functional test covering this scenario.

ioweb-gr · 2019-05-22T08:35:38Z

Only collaborators can reopen issues they closed though so it's out of out hands but one choice would be to mark the duplicates when found and reopen the originals I guess in such cases.

I'm sure you agree that since we can't reopen them, and commenting on the closed is never read, our only option as users is to raise a new issue

m2-assistant · 2019-05-24T09:01:35Z

Hi @Nazar65. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
4. Verify that the issue is reproducible on 2.3-develop branch
Details
- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

5. Verify that the issue is reproducible on 2.2-develop branch.
Details
- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

Join Magento Community Engineering Slack and ask your questions in #github channel.

Nazar65 · 2019-05-24T09:02:10Z

@magento-engcom-team give me 2.3-develop instance

magento-engcom-team · 2019-05-24T09:02:12Z

Hi @Nazar65. Thank you for your request. I'm working on Magento 2.3-develop instance for you

magento-engcom-team · 2019-05-24T09:02:54Z

Hi @Nazar65, here is your Magento instance.
Admin access: https://i-22964-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

magento-engcom-team · 2019-05-24T09:06:21Z

✅ Confirmed by @engcom-backlog-nazar
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-99821 were created

Issue Available: @engcom-backlog-nazar, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Nazar65 · 2019-05-24T09:08:10Z

https://github.com/magento/magento2/pull/18578/files related "PR" may be help to process on this issue.

ghost · 2019-05-24T09:09:57Z

Sorry, @stoleksiy, label Issue: Confirmed can be removed by Community Maintainers only

m2-assistant · 2019-05-28T07:33:15Z

Hi @maheshWebkul721. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
2. Verify that the issue is reproducible on 2.3-develop branch
Details
- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

3. Verify that the issue is reproducible on 2.2-develop branch.
Details
- Add the comment @magento give me 2.2-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x
4. If the issue is not relevant or is not reproducible any more, feel free to close it.

Join Magento Community Engineering Slack and ask your questions in #github channel.

m2-assistant · 2019-10-31T13:53:21Z

Hi @Vitancourt. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
2. Verify that the issue is reproducible on 2.3-develop branch
Details
- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
3. If the issue is not relevant or is not reproducible any more, feel free to close it.

Join Magento Community Engineering Slack and ask your questions in #github channel.

m2-assistant · 2019-10-31T13:57:19Z

Hi @mahsn. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
2. Verify that the issue is reproducible on 2.3-develop branch
Details
- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
3. If the issue is not relevant or is not reproducible any more, feel free to close it.

Join Magento Community Engineering Slack and ask your questions in #github channel.

mahsn · 2019-10-31T14:39:51Z

Reproduced in 2.3.3

Jilco · 2019-11-02T12:27:18Z

Yep, i have the same problem in 2.3.3

sujitcp · 2019-11-02T12:39:12Z

We have Fixed it and will commit soon

m2-assistant · 2019-11-12T13:22:38Z

Hi @cstergianos. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
2. Verify that the issue is reproducible on 2.3-develop branch
Details
- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
3. If the issue is not relevant or is not reproducible any more, feel free to close it.

Join Magento Community Engineering Slack and ask your questions in #github channel.

cstergianos · 2019-11-12T14:47:44Z

@magento-engcom-team I created a pull request for this one here: #25574. Let's hope that this is now fixed.

m2-assistant · 2020-01-05T10:13:48Z

Hi @marcoaacoliveira. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
2. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
3. If the issue is not relevant or is not reproducible any more, feel free to close it.

Join Magento Community Engineering Slack and ask your questions in #github channel.

marcoaacoliveira · 2020-01-05T12:33:31Z

@ioweb-gr I'll work on it.

My first thought about it was changing my interface to Brazil/Portuguese (because we use dd/mm/yyyy format too, hoping that I would face the same problem) for my surprise I could save it in portuguese. When I change it for Greek it really mess something around and I'm not able to save date. So it looks like more a problem with the locale then the date format.

I'll get a more deeply analysis and I'll try to solve it.

ioweb-gr · 2020-01-05T13:37:27Z

@marcoaacoliveira Thanks for taking a look at it first of all. This is such a long standing issue. If you track the original issues you'll see it goes back all the way to 2016 and it occured on Australian locale as well. 4 years later it would be nice to have a real fix or at least a working workaround on this. I've tried to debug this but you have to dig very deep to understand the logic and the proper fix

marcoaacoliveira · 2020-01-05T13:40:58Z

@ioweb-gr I got to the root of the problem, I'll try to solve it today and open a PR.

marcoaacoliveira · 2020-01-05T14:45:06Z

@ioweb-gr I solved it. I'll do some test coverage and I'll open the PR.

It was needed to change the appendTimeIfNeeded, because isn't right to transform DateTime without hour into with hour just appending a string in the end of other string.

marcoaacoliveira · 2020-01-06T08:34:24Z

@ioweb-gr now it's really solved, covered with tests. You can check it requesting a instance for test in the PR if you want:
#26270

VladimirZaets · 2020-01-09T06:14:17Z

Hi @ioweb-gr. Thank you for your report.
The issue has been fixed in #26270 by @marcoaacoliveira in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.0 release.

- Merge Pull Request #26270 from marcoaacoliveira/magento2:2.4-develop - Merged commits: 1. bb16e33 2. d12ac21 3. 32be472 4. 6a19b12 5. 6e80158 6. 8ee89af 7. c85410d

magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label May 21, 2019

Nazar65 self-assigned this May 24, 2019

Nazar65 added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label May 24, 2019

Nazar65 added Component: Catalog Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels May 24, 2019

ghost added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label May 24, 2019

magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label May 24, 2019

ghost added help wanted good first issue labels May 24, 2019

Nazar65 removed their assignment May 24, 2019

soleksii removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label May 24, 2019

ghost added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label May 24, 2019

mahesh-rajawat self-assigned this May 28, 2019

mahsn assigned mahsn and unassigned Vitancourt Oct 31, 2019

mahsn removed their assignment Nov 8, 2019

cstergianos self-assigned this Nov 12, 2019

ghost unassigned cstergianos Dec 7, 2019

marcoaacoliveira self-assigned this Jan 5, 2020

marcoaacoliveira mentioned this issue Jan 5, 2020

Fix #22964 #26270

Merged

4 tasks

marcoaacoliveira added the Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch label Jan 5, 2020

marcoaacoliveira added Component: Framework/Stdlib and removed help wanted labels Jan 6, 2020

VladimirZaets added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Jan 9, 2020

VladimirZaets closed this as completed Jan 9, 2020

magento-engcom-team added a commit that referenced this issue Jan 9, 2020

ENGCOM-6552: Fix #22964 #26270

9a0b5a8

- Merge Pull Request #26270 from marcoaacoliveira/magento2:2.4-develop - Merged commits: 1. bb16e33 2. d12ac21 3. 32be472 4. 6a19b12 5. 6e80158 6. 8ee89af 7. c85410d

magento-engcom-team pushed a commit that referenced this issue Jan 9, 2020

ENGCOM-6552: Fix #22964 #26270

70aefe6

sdzhepa mentioned this issue May 9, 2022

tyutyu sdzhepa/magento2#5

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unable to save any dates if the user interface locale is not english (US) in 2.3.1 #22964

Unable to save any dates if the user interface locale is not english (US) in 2.3.1 #22964

ioweb-gr commented May 21, 2019 •

edited

Loading

m2-assistant bot commented May 21, 2019

ioweb-gr commented May 21, 2019

magento-engcom-team commented May 21, 2019

magento-engcom-team commented May 21, 2019

ioweb-gr commented May 21, 2019

orlangur commented May 22, 2019

ioweb-gr commented May 22, 2019

orlangur commented May 22, 2019

ioweb-gr commented May 22, 2019

m2-assistant bot commented May 24, 2019

Nazar65 commented May 24, 2019

magento-engcom-team commented May 24, 2019

magento-engcom-team commented May 24, 2019

magento-engcom-team commented May 24, 2019

Nazar65 commented May 24, 2019

ghost commented May 24, 2019

m2-assistant bot commented May 28, 2019

m2-assistant bot commented Oct 31, 2019

m2-assistant bot commented Oct 31, 2019 •

edited by mahsn

Loading

mahsn commented Oct 31, 2019

Jilco commented Nov 2, 2019

sujitcp commented Nov 2, 2019

m2-assistant bot commented Nov 12, 2019 •

edited by cstergianos

Loading

cstergianos commented Nov 12, 2019

m2-assistant bot commented Jan 5, 2020

marcoaacoliveira commented Jan 5, 2020

ioweb-gr commented Jan 5, 2020

marcoaacoliveira commented Jan 5, 2020

marcoaacoliveira commented Jan 5, 2020

marcoaacoliveira commented Jan 6, 2020 •

edited

Loading

VladimirZaets commented Jan 9, 2020

Unable to save any dates if the user interface locale is not english (US) in 2.3.1 #22964

Unable to save any dates if the user interface locale is not english (US) in 2.3.1 #22964

Comments

ioweb-gr commented May 21, 2019 • edited Loading

Preconditions (*)

Steps to reproduce (*)

Expected result (*)

Actual result (*)

m2-assistant bot commented May 21, 2019

ioweb-gr commented May 21, 2019

magento-engcom-team commented May 21, 2019

magento-engcom-team commented May 21, 2019

ioweb-gr commented May 21, 2019

orlangur commented May 22, 2019

ioweb-gr commented May 22, 2019

orlangur commented May 22, 2019

ioweb-gr commented May 22, 2019

m2-assistant bot commented May 24, 2019

Nazar65 commented May 24, 2019

magento-engcom-team commented May 24, 2019

magento-engcom-team commented May 24, 2019

magento-engcom-team commented May 24, 2019

Nazar65 commented May 24, 2019

ghost commented May 24, 2019

m2-assistant bot commented May 28, 2019

m2-assistant bot commented Oct 31, 2019

m2-assistant bot commented Oct 31, 2019 • edited by mahsn Loading

mahsn commented Oct 31, 2019

Jilco commented Nov 2, 2019

sujitcp commented Nov 2, 2019

m2-assistant bot commented Nov 12, 2019 • edited by cstergianos Loading

cstergianos commented Nov 12, 2019

m2-assistant bot commented Jan 5, 2020

marcoaacoliveira commented Jan 5, 2020

ioweb-gr commented Jan 5, 2020

marcoaacoliveira commented Jan 5, 2020

marcoaacoliveira commented Jan 5, 2020

marcoaacoliveira commented Jan 6, 2020 • edited Loading

VladimirZaets commented Jan 9, 2020

ioweb-gr commented May 21, 2019 •

edited

Loading

m2-assistant bot commented Oct 31, 2019 •

edited by mahsn

Loading

m2-assistant bot commented Nov 12, 2019 •

edited by cstergianos

Loading

marcoaacoliveira commented Jan 6, 2020 •

edited

Loading