Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

di:setup:compile fails with anonymous classes #26532

Closed
joni-jones opened this issue Jan 24, 2020 · 3 comments
Closed

di:setup:compile fails with anonymous classes #26532

joni-jones opened this issue Jan 24, 2020 · 3 comments
Assignees
Labels
Component: Framework/Setup USE ONLY for FRAMEWORK RELATED BUG! E.g If bug occurs during Catalog Setup use just Catalog Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed

Comments

@joni-jones
Copy link
Contributor

joni-jones commented Jan 24, 2020

Preconditions (*)

The current implementation of \Magento\Setup\Module\Di\Code\Scanner\PhpScanner does not support classes that contain anonymous classes. This leads to failures for di:setup:compile command. The problem that PhpScanner treats anonymous classes as classes that might require code generation for factories and extension attributes.

All Magento versions have this issue.

Steps to reproduce (*)

  1. Create a dummy class which contains an anonymous class, like Magento\DummyModule\Dummy (see a sample below)
  2. Run bin/magento setup:di:compile CLI command

Expected result (*)

  1. Compilation is successful

Actual result (*)

  1. Compilation fails with an error Class \Magento\DummyModule\$arg does not exist

Sample class:

namespace Magento\DummyModule;

class Dummy
{
    public function execute($arg)
    {
        return new class($arg) {
            private $arg;

            public function __construct($arg)
            {
                $this->arg = $arg;
            }

            public function serialize()
            {
                return (string) $this->arg;
            }
        };
    }
}

To achieve the same error as described in #21555, the anonymous class should not provide a possibility to specify arguments for a constructor. In simple words, return new class {.

@m2-assistant
Copy link

m2-assistant bot commented Jan 24, 2020

Hi @joni-jones. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@joni-jones do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jan 24, 2020
@joni-jones joni-jones self-assigned this Jan 24, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jan 24, 2020

Hi @joni-jones. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!


@joni-jones joni-jones added the Component: Framework/Setup USE ONLY for FRAMEWORK RELATED BUG! E.g If bug occurs during Catalog Setup use just Catalog label Jan 24, 2020
joni-jones added a commit to joni-jones/magento2 that referenced this issue Jan 29, 2020
 - Small refactoring for code simplification
@slavvka
Copy link
Member

slavvka commented Feb 9, 2020

Hi @joni-jones. Thank you for your report.
The issue has been fixed in #26533 by @joni-jones in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.0 release.

@slavvka slavvka added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Feb 9, 2020
@slavvka slavvka closed this as completed Feb 9, 2020
magento-engcom-team pushed a commit that referenced this issue Feb 9, 2020
 - Fixed parsing for anonymous classes during di:compile run
 - Small code optimizations
 - Extended and refactored related unit tests
magento-engcom-team added a commit that referenced this issue Feb 9, 2020
…sses #26533

 - Merge Pull Request #26533 from joni-jones/magento2:G#26532
 - Merged commits:
   1. fd3f2a2
   2. 136d559
   3. 25fd925
   4. e165d99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Framework/Setup USE ONLY for FRAMEWORK RELATED BUG! E.g If bug occurs during Catalog Setup use just Catalog Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed
Projects
None yet
Development

No branches or pull requests

3 participants