Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration Tests: Consecutive dispatch($uri) on Test AbstractController fails #27299

Closed
lbajsarowicz opened this issue Mar 16, 2020 · 2 comments
Closed

Integration Tests: Consecutive dispatch($uri) on Test AbstractController fails #27299

lbajsarowicz opened this issue Mar 16, 2020 · 2 comments
Assignees
@lbajsarowicz
Labels
Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Reported on 2.4.0 Indicates original Magento version for the Issue report.

Comments

@lbajsarowicz
Copy link
Contributor

Preconditions (*)

  1. Integration Tests in Magento 2.4-develop

Steps to reproduce (*)

  1. Create a test that uses \Magento\TestFramework\TestCase\AbstractController::dispatch for dispatching controller.
  2. Add the second request to any other URI.

Expected result (*)

  1. Both requests are dispatched

Actual result (*)

  1. First request is dispatched
  2. Second request throws InvalidArgumentException: Invalid return type
@m2-assistant
Copy link

m2-assistant bot commented Mar 16, 2020

Hi @lbajsarowicz. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@lbajsarowicz do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@lbajsarowicz lbajsarowicz mentioned this issue Mar 16, 2020
Merged
4 tasks
@ghost ghost assigned lbajsarowicz Mar 16, 2020
@lbajsarowicz lbajsarowicz changed the title Integration Tests: Consequent dispatch($uri) on Test AbstractController fails Integration Tests: Consecutive dispatch($uri) on Test AbstractController fails Mar 16, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Mar 26, 2020
magento-engcom-team added a commit that referenced this issue Apr 18, 2020
@magento-engcom-team
ENGCOM-7143: FIX #27299 Consecutive Requests in Integration Tests fai…
b0333fb 
…ling #27300

 - Merge Pull Request #27300 from lbajsarowicz/magento2:bugfix/integration-test-requests
 - Merged commits:
   1. 5d0c972
   2. ba8d366
   3. 4286297
   4. 5a2673d
magento-engcom-team pushed a commit that referenced this issue Apr 18, 2020
@slavvka
ENGCOM-7143: FIX #27299 Consecutive Requests in Integration Tests fai…
111f27f 
…ling #27300
magento-engcom-team added a commit that referenced this issue Apr 18, 2020
@magento-engcom-team
🔃 [Magento Community Engineering] Community Contributions - 2.4-devel…
c163118 
…op latest changes

Accepted Community Pull Requests:
 - #27846: [MFTF] Use StorefrontOpenCartPageActionGroup to go to Checkout page (by @Usik2203)
 - #27300: FIX #27299 Consecutive Requests in Integration Tests failing (by @lbajsarowicz)
@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz. Thank you for your report.
The issue has been fixed in #27300 by @lbajsarowicz in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.0 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label May 1, 2020
@magento-engcom-team magento-engcom-team added the Reported on 2.4.0 Indicates original Magento version for the Issue report. label Nov 13, 2020
This was referenced May 9, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lbajsarowicz lbajsarowicz

Labels
Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Reported on 2.4.0 Indicates original Magento version for the Issue report.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lbajsarowicz @sdzhepa @magento-engcom-team