Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove laminas-config dependency from composer.json #31082

Closed
sivaschenko opened this issue Nov 27, 2020 · 3 comments
Closed

Remove laminas-config dependency from composer.json #31082

sivaschenko opened this issue Nov 27, 2020 · 3 comments
Assignees
Labels
Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Progress: done Project: PHP8

Comments

@sivaschenko
Copy link
Member

Description (*)

In order to support PHP 8, the laminas/laminas-config dependency version should be either updated from "^2.6.0" to "^3.4.0" or removed as a dependency.

See the migration guide provided by laminas: https://docs.laminas.dev/laminas-config/migration/to-v3/

As there are no usages of laminas-config in the codebase, it appears the dependency should be removed

What should be done

  1. Remove laminas/laminas-config from composer.json
  2. Run composer update nothing to update the lock file
@m2-assistant
Copy link

m2-assistant bot commented Nov 27, 2020

Hi @sivaschenko. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ProkopovVitaliy
Copy link
Contributor

@magento i am working on this

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, @ProkopovVitaliy.

Thank you for your report and collaboration!

The related internal Jira ticket MC-39656 was closed as Complete.

The fix will be available with the upcoming 2.4.3 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Progress: done Project: PHP8
Projects
None yet
4 participants