-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue] Sales Rules regression in 2.4.7 #38671
Comments
Hi @Nuranto. Thank you for your report.
Join Magento Community Engineering Slack and ask your questions in #github channel. |
Hi @engcom-Dash. Thank you for working on this issue.
|
@magento give me 2.4-develop instance |
Hi @engcom-Dash. Thank you for your request. I'm working on Magento instance for you. |
Hi @engcom-Dash, here is your Magento Instance: https://93af9f9cd29e6a619d3f129b984079ca.instances-prod.magento-community.engineering |
Hi @Nuranto Thanks for reproting and collaboration. Verified the issue on both 2.4 dev and 2.4.7 instances but the issue is not reproducable. Steps to reproduce
Coupon code = test
We are able to apply the coupon code successfully. Please refer the attached screenshots. Let us know if we missed anything. |
Hello @engcom-Dash |
Hi @Nuranto Verified the issue on magento 2.4 dev instance and the issue is reproducible. Steps to reproduce Create a sales rule with : Apply 'test' coupon to a frontend cart with a shipping amount. Getting a coupon code is invalid. Hence, confirming this issue. Please refer the attached screenshots. Note : In 2.4.7 the option SKU under "product attribute combination" is not present. We are not able to see the option. Please refer the screenshot. |
✅ Jira issue https://jira.corp.adobe.com/browse/AC-11876 is successfully created for this GitHub issue. |
✅ Confirmed by @engcom-Dash. Thank you for verifying the issue. |
❌ You don't have permission to export this issue. |
@magento give me 2.4-develop instance |
Hi @glo17720. Thank you for your request. I'm working on Magento instance for you. |
Hi @glo17720, here is your Magento Instance: https://93af9f9cd29e6a619d3f129b984079ca.instances-prod.magento-community.engineering |
Hello, As I can see this issue got fixed in the scope of the internal Jira ticket AC-11876 by the internal team Thanks |
Preconditions and environment
Steps to reproduce
Expected result
Rule is applied. Discount of 1€ is applied on shipping amount
Actual result
Cannot add coupon to cart (invalid coupon)
Additional information
We had rules like this to add discount on shipping amount (and shipping amount only). It worked perfectly in previous versions, but does not work anymore in 2.4.7.
Regression happened in this commit : 79d57b4 where line
$this->rulesApplier->maintainAddressCouponCode($address, $rule, $this->getCouponCode());
has been removed. @sivaschenko / @bl4de : was there a reason ?Release note
No response
Triage and priority
The text was updated successfully, but these errors were encountered: