Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to cart issue #4177

Closed
ovekeryk opened this issue Apr 15, 2016 · 6 comments
Closed

Add to cart issue #4177

ovekeryk opened this issue Apr 15, 2016 · 6 comments
Labels
bug report Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release

Comments

@ovekeryk
Copy link

ovekeryk commented Apr 15, 2016

Preconditions

  1. Magento 2.1

Steps to Reproduce

  1. Set "Qty Uses Decimals" field is set to "yes" for a product
  2. Add product to cart with quantity "0"

Actual result

  1. "We don't have as many "xxx" as you requested."

Expected result

  1. Product is added to the cart

Additional informaion

Better to use value from "Minimum Qty Allowed in Shopping Cart" field of inventory module when it enabled instead of "1".

ref: https://github.com/magento/magento2/blob/develop/app/code/Magento/Quote/Model/Quote/Item.php#L306

@heyitsroberthe
Copy link
Contributor

Hi,

It looks like we can definitely make improvements to the Advanced Inventory settings with regards to quantities involving decimals. Your suggestion to the qty check makes sense as well.

@piotrekkaminski
Copy link
Contributor

Internal issue MAGETWO-53429

@vkorotun vkorotun removed the CS label Aug 4, 2016
@veloraven veloraven added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Oct 26, 2016
@ashburystudios
Copy link

Hi all, Any update on this. Need this ASAP to work on a new site and cant move forward. Thank you, Mike

@degaray
Copy link

degaray commented Jan 8, 2017

I have the same issue.

@magento-engcom-team magento-engcom-team added bug report Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Sep 11, 2017
@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed 2.1.x Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Oct 1, 2017
@magento-engcom-team
Copy link
Contributor

@AlexanderVekerik, thank you for your report.
The issue is already fixed in develop branch, 2.2.0

@ravihandsintechnology
Copy link

ravihandsintechnology commented Dec 19, 2017

i am trying to update cart with the help of rest/v1/carts/cartid/items/itemid

the product is updating sucessfully when the stock of the product is greater than 1
but when the stock is 1 the product is not updating

it gives error
stdClass Object
(
[message] => We don't have as many "product name" as you requested.
)

magento-engcom-team pushed a commit that referenced this issue May 8, 2019
MQE-1532: Bump MFTF version in Magento - 2.2-develop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release
Projects
None yet
Development

No branches or pull requests