Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable product is not added to cart, when using "add to cart" on category page. #4184

Closed
martins-scandiweb opened this issue Apr 18, 2016 · 25 comments
Assignees
Labels
bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@martins-scandiweb
Copy link

martins-scandiweb commented Apr 18, 2016

In http://magento2-demo.nexcess.net/men/tops-men/jackets-men.html

if I choose size and color and then press "add to cart", then I get redirected to product detail page with message "You need to choose options for your item."

Expected result

  1. Configurable product is added to cart and success message is shown and user stays on category page.
@parekhreena
Copy link

Same issue reported earlier here reference id - #2574

@piotrekkaminski
Copy link
Contributor

Internal ID MAGETWO-47017

@rickwhitehead
Copy link

Any progress on this issue please? Can I help investigate?

@rickwhitehead
Copy link

Hi @piotrekkaminski can I get involved with this? It's a show stopper for me.

@rickwhitehead
Copy link

@tanya-soroka ??

@piotrekkaminski
Copy link
Contributor

cc @elenleonova
@rickwhitehead it's on our backlog but might take some time to implement.

@devhn
Copy link

devhn commented Sep 14, 2016

Any news on this? The error messages are also missplaced by showing below the add-to-cart button instead next to non-selected attribute.

@rickwhitehead
Copy link

@piotrekkaminski @tanya-soroka how do we get involved please?

@rickwhitehead
Copy link

IS THERE A PULL REQUEST? IS ANYBODY DOING ANYTHING? PLEASE RESPOND!

@veloraven
Copy link
Contributor

We are working on this issue.

@veloraven veloraven added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Oct 26, 2016
mmansoor-magento pushed a commit that referenced this issue Nov 9, 2016
MAGETWO-54365 [GitHub] Bundle Products - The price calculation fails for user defined quantity #4446
MAGETWO-47017 [Github] Add Configurable Product To Cart from Category Page #2574 #5850 #5882 #6572 #5558 #4184
@rganin
Copy link
Contributor

rganin commented Nov 9, 2016

Fixed under MAGETWO-47017 ticket.

@rganin rganin closed this as completed Nov 9, 2016
@rickwhitehead
Copy link

Is there a pull request for this fix please?

@carlowens
Copy link

Hi,
Could anyone tell me which specific version of Magento 2 has this fix? Has it been released yet?
Thanks

@JDavidVR
Copy link
Contributor

@carlowens it works without problem on 2.1.x

@carlowens
Copy link

ah ok I am using Magento ver. 2.1.1 but it doesn't seem to be working. Does each configurable product need it's own attribute set with a default?

@rickwhitehead
Copy link

@rganin if this issue is fixed please could you link to the pull request or advise of the fix so that people don't waste their time in this repository?

@antonkril
Copy link
Contributor

antonkril commented Nov 29, 2016

@rickwhitehead, @carlowens, the issue was fixed on develop branch: e643a67

It's scheduled to be merged to 2.1.4

Sorry for the lack of info. We'll discuss issue closing report with more information.

@rganin
Copy link
Contributor

rganin commented Nov 29, 2016

@rickwhitehead there is no public pull-request for this fix, it was implemented under following revisions:
27d2486, cce06d2, d8a2550, 4b96c90, 0025497, 7420329, ac363e4 in develop branch and merged in e643a67.

@rickwhitehead
Copy link

Thank you @rganin, @antonkril & @alankent.
Asking for myself but also for others who might find this thread/issue: Would you advise simply cloning the current develop branch to implement this fix? or would you patch using files from those 7 commits?

@antonkril
Copy link
Contributor

antonkril commented Nov 30, 2016

"Develop" branch is not stable, so you should not use it to build production stores.

If this fix is critical for your project, you can apply the patch. But be aware that patch might be not 100% compatible with your codebase or may cause some new issues.

The most preferred way is to wait till the new Magento version with this patch included is released.

@rickwhitehead
Copy link

Hi @antonkril , thank you for your speedy response.
I can't imagine that this bug isn't 100% critical for all but the most very basic of stores, but maybe that's just me? I highlighted this bug for a number of extension developers when I was looking for a workaround - so I'm sure this issue is a show stopper for many. However, Is there a roadmap for Magento 2 releases that we can view/track please? Obviously in particular this thread is interested in v2.1.4. Thank you.

@rickwhitehead
Copy link

@antonkril , @alankent Please could you respond with timelines/roadmap for next M2 releases?
Looking at the commits that @rganin mentioned for this fix I can already see new files that didn't exist in the last "stable" release v2.1.1, e.g. /dev/tests/functional/tests/app/Magento/Swatches/* and hunting through parent commits to see when these were added is also not that helpful. I'll be back to either using dev branch or grabbing all 50 files from that referenced pull request?

@rickwhitehead
Copy link

rickwhitehead commented Dec 2, 2016

@antonkril @alankent?
on commit 0025497 merged in e643a67 please can I ask why we now have files in /app/code/Magento/ when /app/code doesn't exist in current stable releases 1.1.X ??? I'm busy trying to merge/patch to test this fix and of course this list of 7 commits only records

@sneakingJ
Copy link

@antonkril Are there any news on this? When will version 2.1.4 come out?

@helicops
Copy link

helicops commented Feb 6, 2017

Is there any news about this patch?

magento-engcom-team pushed a commit that referenced this issue May 10, 2019
[mpi] MAGETWO-98462: Shopping cart does not show all four digits of quantity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests