Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show/hide Editor not working sometimes #4828

Closed
devishreebalasubramanian opened this issue Jun 2, 2016 · 54 comments
Closed

Show/hide Editor not working sometimes #4828

devishreebalasubramanian opened this issue Jun 2, 2016 · 54 comments
Labels
bug report Component: Cms Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@devishreebalasubramanian
Copy link

devishreebalasubramanian commented Jun 2, 2016

Hai,

I have faced this problem when i edit content in CMS -> Pages.Show/hide editor doesn't work sometimes.Eventhough i have removed all content and save it doesn't work.I can't see any js error in console. So please let me know how to solve this.

@devishreebalasubramanian
Copy link
Author

Show/hide editor worked after i sign out admin panel.

@shiftedreality
Copy link
Member

Hi @devishreebalasubramanian

What is your browser name/version and OS?

@shiftedreality
Copy link
Member

No update was received from the author.
Closed as non-reproducible.

@devishreebalasubramanian
Copy link
Author

Hai,

Sorry for too late reply. I have used Firefox 43.0 in ubuntu 14.0.

@AeroBob93
Copy link

AeroBob93 commented Jul 4, 2016

I have the same error, it seems really 50/50. When it doesnt show the show/hide button doesnt work (and no js errors), but when the editor shows the button does work. First I thought it was a browser issue but switching didnt seem to help.

It happens not only with CMS, but with adding/editing products as well.

Using Chrome and Safari latest version, PHP 7.0.7, Magento in dev mode and cache off.

@koenner01
Copy link
Contributor

koenner01 commented Jul 15, 2016

We are having the same problem;
tried on: Chrome, Firefox & Safari
php: 7.0.7
developer mode
cache on & off

We think it has something to do with the order in which the js are executed. Because if you refresh you page it's indeed 50/50 chance it will work.

*Edit: it's the editor_plugin.js that's not loaded sometimes

@luxwan13
Copy link

luxwan13 commented Sep 1, 2016

Has anyone come up with a solution for this? I am having exactly the same problem.

@shiftedreality
Copy link
Member

Looks like it still issue. Reopened.

@koenner01, @luxwan13 which version of Magento do you use?

@shiftedreality shiftedreality reopened this Sep 1, 2016
@hostep
Copy link
Contributor

hostep commented Sep 1, 2016

@koenner01 is on holiday, so I'll answer in his name: we use Magento CE 2.1.0

@shiftedreality
Copy link
Member

@hostep, thank you for the fast answer.

Created internal ticket MAGETWO-57911 to investigate this issue.

@luxwan13
Copy link

@shiftedreality
I am using version 2.1.0

@hostep
Copy link
Contributor

hostep commented Sep 16, 2016

In case this helps someone. This problem mostly happens when you have enabled JS Bundling.
When you disable JS Bundling, most of the time (not always) the Show/Hide button does work correctly.
And I've also seen it work one single time with JS Bundling enabled.

So I'm pretty sure this issue is because a dependency is incorrectly defined (using requirejs?) and sometimes the correct js files are loaded before other js files and sometimes not which in this case causes this issue (not properly debugged, because it's a hell to debug js when bundling is enabled).

As a temporary workaround, I was trying to disable JS Bundling only in the adminhtml and keep it enabled in the frontend, but unfortunately this doesn't work at all. I've opened a new issue for this new bug...

And I'm also linking some related/duplicate issues here, since they weren't linked already:

@VladimirZaets
Copy link
Contributor

As an investigation shows, the problem is inside 3d party library tinymce, which we shouldn't modify. TinyMCE uses own Event manager and when we call tinymce.init() tinymce sometimes doesn't trigger ‘init’ event itself, so initialise doesn’t execute.

@tkacheva
Copy link

@hostep @luxwan13 @shiftedreality @koenner01
there is an issue in tinyMCE itself that we can't fix as it's 3d party library. We are working on updating WYCIWYG plugin in Magento.

@sergiojovanig
Copy link

I can confirm this bug in Magento 2.1.1.

As @hostep says, I had JS Bundling enabled. Once I disabled it, editor started working.

Thanks @hostep

@hostep
Copy link
Contributor

hostep commented Sep 29, 2016

@tkacheva: can you elaborate a little bit on your comment?
Are you saying you are trying to make the TinyMCE plugin working in the current codebase, or are you going to drop it entirely and replace it with something else?
If the last one is the case, then it will probably take months until we see an improvement here, right?

Because currently this issue is preventing us from putting shops into production since non-technical shopowners have a really hard time entering html syntax.

It would be very much appreciated if this issue could get some higher priority.
Thanks!

@tkacheva tkacheva added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Component: Cms labels Oct 5, 2016
mmansoor-magento pushed a commit that referenced this issue Oct 19, 2016
[Folks] Bugs
- MAGETWO-58334 [Github] Free shipping is not applied if cart price rule match #6584
- MAGETWO-57278 For Dutch locale, ZIP in checkout is already giving out a "validation failed" error at page load
- MAGETWO-57675 [GITHUB] WYSIWYG editor does not show. #6222 #4828 #6815
- MAGETWO-56836 [FT] Update wishlist button doesn't receive the click in AddProductsToCartFromCustomerWishlistOnFrontendTest
- MAGETWO-54412 [MERCHANT] Integrity Constraint Violation when creating orders #4580
- MAGETWO-58730 [Github] Incorrect province code sent on Checkout to UPS #6564
@SerhiyShkolyarenko
Copy link
Contributor

Fix is delivered to the develop branch. @shiftedreality can you close the issue?
Issues for backporting to 2.0.x and 2.1.x branches are MAGETWO-59691 and MAGETWO-59688 correspondingly.

@deryan12
Copy link

deryan12 commented Apr 6, 2017

@mailtomayaz that's work

@onepack
Copy link

onepack commented Apr 6, 2017

As a quick workaround I also discovered that after the page has loaded one simple f5 on that page does the trick to load the WYSIWYC editor.

@TiEul
Copy link

TiEul commented Apr 10, 2017

This is definitely still an issue that majorly impacts usability, when can we expect a fix here?

@reijervano
Copy link

Still not working on 2.1.5 :(

@termeitz
Copy link

I am also having this problem on 2.1.4.

@dfelton
Copy link
Contributor

dfelton commented May 3, 2017

Confirming that @mailtomayaz's comment seems to work.

hostep pushed a commit to hostep/magento2 that referenced this issue May 3, 2017
magento-team pushed a commit that referenced this issue May 8, 2017
…tor does not show. #6222 #4828 #6815 #9499

 - Merge Pull Request #9499 from hostep/magento2:backport-magetwo-57675
magento-team pushed a commit that referenced this issue May 8, 2017
[EngCom] Public Pull Requests - 2.1

 - MAGETWO-68903: Backport of MAGETWO-57675 for Magento 2.1: WYSIWYG editor does not show. #6222 #4828 #6815 #9499
 - MAGETWO-68902: Backport of MAGETWO-54798 For Magento 2.1: One page checkout - Street Address should highlight red when data is missing #9500
@br0k3n
Copy link

br0k3n commented Jun 9, 2017

Unfortunately the fix suggested by magento-team doesnt' work...

@romeof1980
Copy link

hi @br0k3n ,
that works for me: eebdb8c
don't know it you meant this fix.

please make sure you clear the cache (clear at least this js file cache in CDN too)

cheers

@treestonemedia
Copy link

still doesn't work for us on 2.1.6

@gerryka
Copy link

gerryka commented Jul 26, 2017

The workaround posted by @mailtomayaz worked for us on 2.1.7.

We still require a definitive fix for this!

@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-68903

@farhadfrz
Copy link

We get the same issue after upgrading to 2.1.9!
Bundling and Minify JS are both enabled.

@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Sep 27, 2017
@philtdev
Copy link

philtdev commented Oct 3, 2017

This intermittent loading of the WYSIWYG editor appears in development mode on 2.1.8 - sometimes it loads, sometimes it doesn't. In production mode, the WYSIWYG editor does not work at all, throwing JavaScript errors, attached.

console-errors

@maqlec
Copy link
Contributor

maqlec commented Jan 12, 2018

@OnePhilT your browser tries to load minified tiny_mce. It shouldn't be minified. Your have to use extension which overrides dev/js/minify_exclude setting. In my case It was MSP_ReCaptcha.

@philtdev
Copy link

Thanks, @maqlec. I realised about the JavaScript minification issue when I subsequently followed other threads. I think this issue wasn't resolved in version 2.2.2, although I managed a workaround to avoid minifying TinyMCE JavaScript.

@maqlec
Copy link
Contributor

maqlec commented Mar 21, 2018

As I saw in another thread, it has fixed in 2.3-develop branch

@duffner
Copy link

duffner commented May 7, 2018

@magento-engcom-team & @shiftedreality, after reviewing this thread it appears no action has occurred for 2.2.x versions. I'm on 2.2.4 the latest iteration and it's still an issue. These are the types of issues that give Magento a bad reputation. Is there a backported patch for 2.2.4?

Since I'll likely not get a direct answer, @OnePhilT what did you do to solve the issue? I see solutions from modifying JS to wait for DOM loaded, removing it from minification, to enabling WYSIWYG by default, deleting all generated files and starting over. I mean if it can be fixed without any code changes that would be great, but any suggestions are welcome!

@hostep
Copy link
Contributor

hostep commented May 7, 2018

@duffner: the original reported bug was fixed in 3524943 for Magento 2.2.x and in 6b07d07 for Magento 2.1.x

If you can still reproduce this bug on 2.2.4, it might be best if you create a new issue with exact steps of how to reproduce on a clean installation preferably. Thanks!

@matin73
Copy link

matin73 commented Jun 27, 2018

I have same issue on magento 2.2.4 as @duffner said. after upgrading from 2.2.3 (where editor works) on 2 shops to magento 2.2.4 editor is broken if js is bundeled

@hostep
Copy link
Contributor

hostep commented Jun 27, 2018

@matin73: please try updating the Klarna modules to the latest version using composer, or just disable them if you don't use those, it should fix the problem in 2.2.4 (btw: it was caused by a different bug in 2.2.4, not by the one which was discussed in this thread).

@kanenas
Copy link

kanenas commented Mar 27, 2020

Is this issue resolved? I have a 2.1.5 installation with is problem.

@hostep
Copy link
Contributor

hostep commented Mar 28, 2020

@kanenas: it was resolved, but not sure if that happened before 2.1.5 was released. However, I would strongly advise you to upgrade to a newer Magento version, version 2.1.5 is really old and no longer supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Component: Cms Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests