Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate attribute values #4881

Closed
RG-1 opened this issue Jun 5, 2016 · 5 comments
Closed

validate attribute values #4881

RG-1 opened this issue Jun 5, 2016 · 5 comments
Labels
Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@RG-1
Copy link

RG-1 commented Jun 5, 2016

Steps to reproduce

  1. Go to Stores > Product Attributes
  2. Create new or edit any existing attribute (types: dropdown, swatches or multiple select)
  3. Add few identical attribute values

Expected result

  1. Error - it should not allow to create identical attribute values for "admin"

Actual result

  1. No errors
@mslabko mslabko added the MX label Jun 8, 2016
@antboiko
Copy link

antboiko commented Jun 8, 2016

Hi @RG-1 , thanks for your inquiry. Could you please provide some specific use cases why attribute should not be saved if user added non-unique values to it?

Thanks,
Anton.

@RG-1
Copy link
Author

RG-1 commented Jun 9, 2016

Hello Anton,

Dropdown list and swatches are used in configurable products and layered navigation, so values should be precise. Otherwise, it may create confusion and wrong assignment. When dropdown is used just to create additional information, then it doesn't matter much.

Configurable products
Creating Product Configurations [Products > Catalog > Add product or Edit] allow to select same values and generate simple products from attribute like this:
red
red2

It looks like this on front-end product page:
red1

I tried to import products form csv file, similar to this:

sku product_type additional_attributes configurable_variations
s1 simple color=red
s2 simple color=black
s3 simple color=red
c configurable sku=s1,color=red|sku=s2,color=black|sku=s3,color=red

Produsts are imported, but only s1 and s2 are used in configuration, s3 is skipped (without any error).

Management
It is hard to manage attributes with a lot of values. Let's assume that we have about 100 values of a color attribute and there is a need to add 100 new colors. It is possible to check it manually, but it would not be the smart way.

Best

@antboiko
Copy link

Hi @RG-1 , sorry for the delayed response. I've created internal ticket MAGETWO-54780 to track this issue on our side.

Thanks,
Anton.

@antboiko antboiko added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development and removed Progress: needs update labels Jun 27, 2016
@vkorotun vkorotun removed the MX label Aug 4, 2016
@andimov
Copy link
Contributor

andimov commented Aug 16, 2016

@RG-1
This issue has been fixed and delivered to mainline.

@andimov andimov closed this as completed Aug 16, 2016
okorshenko pushed a commit that referenced this issue Dec 14, 2016
okorshenko pushed a commit that referenced this issue Dec 14, 2016
Fixed issues:
- MAGETWO-58090: [Magento Cloud] - Intermittent HTTP ERROR 500 during checkout 
- MAGETWO-59024: [Github] Ship To section on Checkout's Review & Payments step, clears out the Ship To address on page reload
- MAGETWO-55447: Portdown MAGETWO-54718 down to M2.1.x branch
- MAGETWO-55662: Portdown MAGETWO-51428 down to M2.1.x branch
- MAGETWO-59209: [Github] Minicart item count is not updated if switch from https to http #6487 
- MAGETWO-56964: [GitHub] Validate attribute values #4881
@elenleonova
Copy link

The issue has been delivered to 2.1.3 and 2.0.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

6 participants