Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Category Layered Navigation : Selection of disabled entity #612

Closed
sankalpshekhar opened this issue Jul 13, 2014 · 2 comments
Closed

Category Layered Navigation : Selection of disabled entity #612

sankalpshekhar opened this issue Jul 13, 2014 · 2 comments
Assignees
@verklov

Comments

@sankalpshekhar
Copy link
Contributor

In Magento\Catalog\Model\Layer\Filter\Category::_isValidCategory() only checks for entity id, thus allows selection of disabled entity, if entity id is directly passed in the url.

Considering the following scenario:
C1 (Active)
C1.1 (Inactive)
C1.1.1 (Active)

If a user lands on C1 landing page and had a previous selection bookmarked for C1.1, they still can view the product selection, and its enabled descendants.

This issue is also visible in Magento1.
@verklov verklov assigned ilol and verklov and unassigned ilol Aug 4, 2014
@verklov
Copy link
Contributor

verklov commented Aug 4, 2014

@sankalpshekhar, thank you for reporting this issue to us! We created the ticket int he internal backlog and will get back to you once we have an update on this issue.

magento-team added a commit that referenced this issue Sep 1, 2014
@magento-team
0.1.0-alpha93
a2ea67f 
* Price template refactoring
   * Refactored order item templates in the Sales, Bundle and Downloadable modules
   * Eliminated the unused PHTML templates and removed the direct dependencies on the TaxHelper module in the Catalog module
 * Service layer implementation:
   * Created service layer for Order creation
   * Created service layer for Invoice
   * Created service layer for Credit Memo
   * Created service layer for Shipment
 * Introduce the Search library:
   * Created adapter interfaces for the Search library
   * Created response structure
   * Created parsing of XML declaration and creation of library objects (Queries, Filters, Aggregations)
 * Refactored Framework\Stdlib\Cookie to use CookieManager
 * Added the ability to prevent the backend cookie from going to the storefront
 * Fixed bugs:
   * Fixed an issue where taxes  were  not added in some orders
   * Fixed an issue were the Add New Address button did not work if the default address was already set
   * Fixed a Google Chrome and Internet Explorer specific issue when a JavaScript error made it impossible to register   during checkout downloadable product
   * Fixed an issue when the credit card iframe (PayPal or 3D secure)  was absent on the Order Review step during Onepage Checkout
   * Fixed an issue with the   Tax Rate, Customer Tax Class and Product Tax Class multiselects on the Tax Rule Information page
   * Fixed JavaScript issues which prevented saving a newsletter template.
   * Modified the Button component behavior
   * Fixed an issue where it was impossible for a guest customer to register during Onepage checkout when the Require Customer To Be Logged In To Checkout option was set to Yes
   * Fixed an issue where the Calendar icons were not displayed on the storefront
   * Fixed an  AJAX loader issue in the Admin panel
   * Fixed an issue where it was impossible to upload images for  variations of a configurable product on product form
   * Fixed an issue where clicking on a row in the Search Terms Report Grid leads to 404 page
   * Fixed an issue where configurable products fixture creates out of stock products
   * Fixed an issue where Magento crashed when invalid cookie domain was set
   * Fixed an issue where the Change checkbox label overlapped the text message for a recurring profile attribute on the attribute mass update page
   * Fixed an issue where integrity test determined normal dependencies as redundant
   * Fixed an issue where Catalog\Service\V1\Product\Attribute\ReadService::search returned an error
   * Fixed an issue where Magento\Catalog\Service\V1\Category\Attribute\ReadService::options returned empty results
 * GitHub requests:
  * [#160] (https://github.com/magento/bugathon_march_2013/issues/160) -- Wrong default value for memory_limit in .htaccess.sample
  * [#480] (#480) -- Provide instructions on adding memcache support for Magento 2
  * [#612] (#612) -- Category Layered Navigation : Selection of disabled entity
  * [#626] (#626) -- Unable to install under IIS / FastCGI
@verklov
Copy link
Contributor

verklov commented Sep 5, 2014

@sankalpshekhar, the team processed the issue that you reported. The fix was deployed with version 0.1.0-alpha93. We are closing this issue.

@verklov verklov closed this as completed Sep 5, 2014
magento-team pushed a commit that referenced this issue Oct 21, 2015
Merge pull request #612 from magento-dragons/MAGETWO-42874
ca40259 
[DRAGONS] Bug Fixes, Merchant Beta
magento-team pushed a commit that referenced this issue May 13, 2016
Merge pull request #612 from magento-vanilla/PR
5471bca 
[Vanilla] Bugfixes
okorshenko pushed a commit that referenced this issue Dec 14, 2016
Merge pull request #612 from magento-okapis/MAGETWO-60479-Import-Prod…
7186af8 
…ucts

[Okapis] MAGETWO-60479: Importing existing products with 'Replace' behavior
magento-engcom-team pushed a commit that referenced this issue Jun 19, 2019
@lenaorobei
Merge branch '2.3-develop##612' of github.com:XxXgeoXxX/graphql-ce in…
f01d084 
…to 612-skip
magento-engcom-team added a commit that referenced this issue Jun 19, 2019
@magento-engcom-team
ENGCOM-5272: Product media_gallery_entries / types only present if im…
1faa43b 
…age, thumbnai… #718

 - Merge Pull Request magento/graphql-ce#718 from XxXgeoXxX/graphql-ce:2.3-develop##612
 - Merged commits:
   1. bb5ae76
   2. b776ec3
   3. f01d084
   4. 44d7ff4
magento-devops-reposync-svc pushed a commit that referenced this issue Dec 22, 2022
@mohit-adobe
Merge pull request #612 from magento-gl/ACQE-4299_testfix
e467b89 
ACQE-4299 | Flaky Test Fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@verklov verklov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sankalpshekhar @verklov @ilol