Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widgets in content pages. #674

Closed
tzyganu opened this issue Sep 23, 2014 · 3 comments
Closed

Widgets in content pages. #674

tzyganu opened this issue Sep 23, 2014 · 3 comments
Assignees

Comments

@tzyganu
Copy link
Contributor

tzyganu commented Sep 23, 2014

When trying to add a widget to a cms page, the widget chooser comes out blank.
If I add a widget manually to the content like this:

 {{widget type="Magento\Catalog\Block\Product\Widget\NewWidget" template="product/widget/new/content/new_grid.phtml"}}

The widget is not rendered in the frontend because the result of the $params = $this->_getIncludeParameters($construction[2]); call in the widgetDirective method is:

array(
    'type' => 'MagentoCatalogBlockProductWidgetNewWidget'
    'template' => 'product/widget/new/content/new_grid.phtml'
)

So the backslashed are stripped. Not sure if this is an issue for be only because I'm working on a windows OS. Most probably is not.
If I double the backslashes

 {{widget type="Magento\\Catalog\\Block\\Product\\Widget\\NewWidget" template="product/widget/new/content/new_grid.phtml"}}

the widget is rendered on frontend, but in the backend the widget icon does not appear when I have the wysiwyg editor enabled.

And a side issue. The route for backend for the widget module looks like this:

 <router id="admin">
    <route id="adminhtml">
        <module name="Magento_Widget" before="Magento_Adminhtml" />
    </route>
</router>

But there is no Magento_Adminhtml module anymore. Also I thought the adminhtml route will be removed.

@verklov verklov self-assigned this Oct 1, 2014
@verklov
Copy link
Contributor

verklov commented Oct 1, 2014

@tzyganu, thank you for reporting this issue! We created the ticket and forwarded it to the team for fixing. We will update you once we resolve it.

@tzyganu
Copy link
Contributor Author

tzyganu commented Nov 7, 2014

This seams almost fixed. The UI for selecting a widget is working, but the image for the widget is not displayed.

magento-team added a commit that referenced this issue Nov 18, 2014
* Various improvements:
    * Merge SQL and Data Upgrades for the Sales and SalesRule modules
    * Add getDefaultBilling and getDefaultShipping to Customer Interface
    * Stabilized the Bundle module
    * Stabilized the CatalogSearch module
    * Stabilized the Cms module
    * Stabilized the SalesRule module
* Performance improvements:
    * Introduced CatalogRule indexers based on Mview
    * Significantly decreased the amount of unused objects, mostly in category and product view scenarios:
		* Got rid of non-shared indexer instances all over the code introducing Magento\Indexer\Model\IndexerRegistry
		* Magento\Catalog\Pricing\Price\BasePrice being created on demand only, instead of unconditioned creation in constructor
		* Created proxies for unused objects with big amount of dependencies
		* Fixed \Magento\Review\Block\Product\Review block which injected backend block context by mistake
		* A customer model in \Magento\Customer\Model\Layout\DepersonalizePlugin being created on demand only, instead of constructor
    * Introduced caching for product attribute metadata loading procedure
    * Improved SavePayment Checkout step to save only payment related data
    * Speed up all Checkout steps of the One Page Checkout
    * Updated the benchmark.jmx jmeter script in the performance toolkit
* Fixed bugs:
    * Fixed an issue where performance toolkit generator created Products/Categories without URL rewrites due to install area elimination
    * Fixed an issue where the Custom Options fieldset on Product Information page was collapsible
    * Fixed an issue where the Base URL was added to target path for Custom UrlRewrite
    * Fixed an issue where an invalid Cross-sells amount was displayed in the Shopping Cart
    * Fixed an issue where the Mage_Catalog_Model_Product_Type_AbstractTest::testBeforeSave integration test failed when Mage_Downloadable module was not available
    * Fixed an issue where the custom URL rewrite redirected to sub-folder when Request Path contained slash
    * Fixed an issue where it was impossible to place an order if registering during checkout
    * Fixed an issue where there was no possibility to save default billing and shipping addresses for customer on the store front
    * Fixed an issue where a widget of Catalog Category Link type was not displayed on the store front
    * Fixed an issue where the Versions tab was absent on the CMS page with version control
    * Fixed an issue where it was impossible to insert Widgets and Images to a CMS page
* Added the following functional tests:
    * Create widget
    * Print order from guest on frontend
* Framework Improvements:
    * Removed duplicated logic from API Builders and Builder generators. Added support for populating builders from the objects, implementing data interface
* Processed GitHub requests:
    * [#674](#674) -- Widgets in content pages
@verklov
Copy link
Contributor

verklov commented Nov 18, 2014

@tzyganu, we are glad to inform you that the team has fixed this issue. The code with the fix has just been deployed to the GitHub. Looking forward to new contributions from you.

@verklov verklov closed this as completed Nov 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants