Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readonly inputs and after element html in the backend #691

Closed
tzyganu opened this issue Oct 14, 2014 · 4 comments
Closed

Readonly inputs and after element html in the backend #691

tzyganu opened this issue Oct 14, 2014 · 4 comments
Assignees
@maksek
Labels
Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed

Comments

@tzyganu
Copy link
Contributor

tzyganu commented Oct 14, 2014

Let's say I have a custom form that contains one input marked as readonly and has an after_element_html value.

 $fieldset->addField('some_id', 'text', array(
     'name' => 'some_name',
     'label' => __('Some Label Here'),
     'readonly' => true,
     'after_element_html' => 'AFTER HTML'
));

The result would be something like this:
After html

The border on the element is continued with a border on whats after the element. But the borders don't match.

But if instead of 'readonly' => true, I use 'disabled' => true, then they match.
So I guess the readonly css should look like the disabled css.

And yes...this is very low priority, but it would be nice to have a consistent UI.
@maksek
Copy link
Contributor

maksek commented Oct 21, 2014

Hi @tzyganu, thanks for your time with Magento 2, and for reporting this case. We have confirmed - there is such issue, and we are going to fix it in upcoming updates.

@maksek maksek self-assigned this Oct 21, 2014
magento-team added a commit that referenced this issue Dec 5, 2014
@magento-team
0.1.0-alpha107
6c51ba0 
* Various improvements:
    * Removed deprecated code from the Sales and SalesRule modules
    * Stabilized functional tests for the following modules:
        * Centinel
        * Core
        * RecurringPayment
        * Sales
        * Multishipping
        * Newsletter
        * Widget
* Fixed bugs:
    * Fixed an issued where a product could not be found in customer wishlist when searched by name
    * Fixed the invalid email template for Product Price Alert
    * Fixed an issue where customer group did not change when invalid VAT number was specified
    * Fixed integration tests coverage
    * Fixed an issue where a customer was not redirected to the configurable product page after clicking Add to Card on the My Wish list page for a product which required configuration
    * Fixed an issue where an error message was displayed when a customer tried to use checkout using PayPal Express Checkout
    * Fixed an issue where it was impossible to place an order using Authorize Direct Post
    * Fixed an issue where the page cache in Varnish mode didnt perform caching as required the cache
    * Fixed an issue where it was impossible to specify layout container when creating or editing a widget
    * Fixed an issue where a widget set to be displayed on certain type of product page was not displayed
    * Fixed an issue where it was impossible to create a widget to be displayed in a sidebar
    * Fixed an issue where a fatal error was thrown when trying to open a not existing page after disabling the 404 Not Found CMS page
    * Fixed an issue where it was impossible to refresh CAPTCHA in the Admin panel
    * Fixed an issue where two CAPTCHAs were displayed during guest Checkout
    * Fixed an issued where clicking the Preview button on revision preview page did not open the Preview page
    * Fixed an issue where the Magento\Framework\View\Element\AbstractBlockTest::testFormatTime failed randomly
    * Fixed logic duplication and the conflicting implementation of the title API in admin
    * Fixed an issue where JavaScript validation did not recognize the fields filled by automatic tests in the Create Customer form in the Admin panel
    * Fixed an issue where a fatal error was thrown after mass update of the Stock Availability product attribute
    * Fixed an issue where the Magento\SalesRule\Model\Resource\Report\CollectionTest::testPeriod CollectionTest::testPeriod integration test failed randomly
    * Fixed issues with expandable frontend elements
    * Fixed Blank & Luma themes UI bugs
    * Fixed an issue where the Packages pop-up displayed incorrect information
    * Fixed an issue where admin path became hidden when store address was too long
    * Fixed the styling of variations without base image
    * Fixed an issue where the Back link on a customer edit page led to the home page
    * Fixed an issue where it was impossible to save system config from Advanced->System
    * Fixed an issue where it was impossible to save a Return in the Admin panel
    * Fixed a JavaScript issue where it was impossible to expand nested categories if responsive
    * Fixed an issue where it was impossible to place an order using Authorize.net Direct Post in the Admin panel
* Framework improvements:
    * Declaration of components in composer.json
    * Added compiler for single-tenant mode
    * Both ZF1 and ZF2 libraries are declared as Composer dependencies as "1.12.9" and "2.3.1" respectively
    * ZF1 library is represented by 'magento/zendframework1', which is based on original "1.12.9" version and includes fixes for compatibility with Magento 2 application
* Layout improvements:
    * Refactored layout building
* Performance improvements:
    * Load product/category instances via repositories
    * Mobile and Desktop CSS styles stored in separate files
* Service Contracts:
    * Refactored the following modules to use new Customer service interfaces:
        * Checkout
        * Sales
        * Multishipping
        * GoogleShopping
        * Persistent
        * SalesRule
        * Paypal
        * Invitation
        * Tax
        * Newsletter
    * Code review changes for Service Contracts for the CatalogInventory module
    * Stabilized code after refactoring the Sales module to use new Customer service
    * Stabilized code after refactoring the Checkout module to use new Customer service
    * Deleted old CustomerAccount service tests
    * Fixed base service object class to populate custom attributes correctly
    * Fixed processing of array parameters in service interface for consolidated builder
    * Fixed trace information for service exceptions in dev mode
    * Implemented Bundle product API
* Accessibility improvements:
    * Heading2-Heading6 hierarchy of content structure
* UI improvements:
    * Style independent Error page in pub/errors styles
    * Updated the content of certain default CMS Pages
* GitHub requests:
    * [#691](#691) -- Readonly inputs and after element html in the backend
    * [#694](#694) -- missing git tags in repo
@verklov
Copy link
Contributor

verklov commented Dec 5, 2014

@tzyganu, we have just deployed the fix for this issue in version 0.1.0-alpha107. Thanks again for contributing to Magento 2!

@verklov verklov closed this as completed Dec 5, 2014
guz-anton added a commit that referenced this issue Oct 14, 2015
@guz-anton
Merge pull request #691 from magento-vanilla/MAGETWO-32170--JS-51
9d31376 
[Sky EPAM] Gallery
mmansoor-magento pushed a commit that referenced this issue Dec 26, 2016
@slavvka
Merge pull request #691 from magento-south/BUGS
25f6bcf 
[SOUTH] Bugs:
- MAGETWO-52925 Simple child product without a special price still shown as "was (original price)" #4442 #5097 #6645 - for mainline
- MAGETWO-60098 Configurable product option price is displayed incorrectly per website
- MAGETWO-56793 [GITHUB][PR] Fix Magento\Review\Model\ResourceModel\Rating\Option not instantiable in setup scripts #5465
- MAGETWO-58078 [FT] CreateProductAttributeEntityFromProductPageTest fails
- MAGETWO-61725 [GITHUB] Improve address save flow to allow to use custom validators #7552
@Rus0 Rus0 mentioned this issue Aug 28, 2019
Closed
4 tasks
@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Nov 27, 2019
@magento-engcom-team
Copy link
Contributor

Hi @tzyganu. Thank you for your report.
The issue has been fixed in #25611 by @drpayyne in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.5 release.

@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Nov 27, 2019
@drpayyne
Copy link
Contributor

@magento-engcom-team That PR was for fixing issue 691 in adobe-stock-integration as mentioned in its description, and not this issue.

@drpayyne drpayyne removed the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maksek maksek

Labels
Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@maksek @tzyganu @verklov @drpayyne @magento-engcom-team