Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swatches-renderer.js not possible to extend without copying template #8500

Closed
OZZlE opened this issue Feb 10, 2017 · 2 comments
Closed

swatches-renderer.js not possible to extend without copying template #8500

OZZlE opened this issue Feb 10, 2017 · 2 comments
Labels
Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release triage wanted

Comments

@OZZlE
Copy link
Contributor

OZZlE commented Feb 10, 2017

Preconditions

  1. Magento version 2.1.2 (and probably latest?)

Steps to reproduce

  1. Inside your custom theme/module add inside requirejs-config.js the mixin or map feature as:
    described here: How to overwrite a javascript component method? #1864
    or map as here http://devdocs.magento.com/guides/v2.0/javascript-dev-guide/javascript/requirejs_concept.html

Expected result

  1. By extending the Magento_Swatches/js/swatch-renderer via requirejs-config.js it should be possible to extend and modify it without copying and changing templates.

Actual result

  1. It is never extended. It doesn't work because inside the module Magento_Swatches the requirejs-config.js file and the path Magento_Swatches/js/swatch-renderer was removed in some version of 2.1. Also it was renamed from swatchRenderer to swatch-renderer without mapping the old name to the new so that also breaks any sites upgrading m2 version if they had extended the swatchesRenderer...

The only way to extend it currenly is like this: http://magento.stackexchange.com/a/136927/6078

@magento-engcom-team magento-engcom-team added G1 Passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed G1 Passed labels Sep 5, 2017
@magento-engcom-team magento-engcom-team added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Nov 10, 2017
@magento-engcom-team magento-engcom-team self-assigned this Nov 10, 2017
@magento-engcom-team
Copy link
Contributor

@OZZlE, thank you for your report.
We've created internal ticket(s) MAGETWO-83680 to track progress on the issue.

@magento-engcom-team magento-engcom-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 10, 2017
@okorshenko okorshenko removed the 2.1.x label Dec 14, 2017
@magento-engcom-team
Copy link
Contributor

@OZZlE, thank you for your report.

Unfortunately, we are archiving this ticket now as it did not get much attention from both Magento Community and Core developers for an extended period. This is done in an effort to create a quality, community-driven backlog which will allow us to allocate the required attention more easily.

You may learn more about this initiative following this link.

Please feel free to comment or reopen the ticket if you think it should be reviewed once more. Thank you for collaboration.

magento-devops-reposync-svc pushed a commit that referenced this issue Sep 4, 2023
…_28082023

Hammer platform health scope 28082023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release triage wanted
Projects
None yet
Development

No branches or pull requests

3 participants