Fix missing extension_attributes on checkout item #10328
Conversation
…dataObject. Otherwise it is not possible to display custom attributes on checkout
| @@ -79,7 +79,6 @@ public function modelToDataObject($item) | |||
| $this->eventManager->dispatch('items_additional_data', ['item' => $item]); | |||
| $items = $item->toArray(); | |||
| $items['options'] = $this->getFormattedOptionValue($item); | |||
| unset($items[ExtensibleDataInterface::EXTENSION_ATTRIBUTES_KEY]); | |||
There was a problem hiding this comment.
These are removed on purpose, as it causes a fatal error due to types mismatch on checkout when extension attribute is populated. There is more detailed explanation of what is happening in this comment to issue 3640.
We are currently looking into a solution which may be safely used in this case. I will update the ticket when we come up with one.
|
@jalogut Unfortunately, we can not accept this PR for now, since this change will cause fatal errors in some scenarios. You may also refer to the Travis CI build for this Pull Request and observe this error. We are going to investigate this issue additionally and looks for possible solution, which would satisfy all cases. For now I would suggest same method as mentioned by @antonkril on twitter: add a plugin on Thank you for collaboration. |
|
@ishakhsuvarov I think it would be good idea to add some comment there why it was done in this way and how we can make workaround. I think this issue already had not only @jalogut and it will happen for another people. What do you think? |
|
@ihor-sviziev Thank you for the feedback. We will consider adding this comment. |
Do not remove extension attributes when converting the quote Item to dataObject. Otherwise it is not possible to display custom attributes on checkout.