Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grammar fix for #9533 #10627

Merged
merged 1 commit into from
Aug 23, 2017
Merged

Grammar fix for #9533 #10627

merged 1 commit into from
Aug 23, 2017

Conversation

insanityfarm
Copy link

@insanityfarm insanityfarm commented Aug 22, 2017 •
edited by orlangur
Loading

Description

Quick fix for verbiage in the authentication popup, changed "checkout out" to "checkout" in two places.

Fixed Issues (if relevant)

  1. Grammar error on authentication popup #9533: Grammar error on authentication popup

Manual testing scenarios

  1. On the frontend with guest checkout disabled, add an item to your cart and proceed to checkout.
  2. The authentication popup that appears has two sections. Validate that the one on the left has a header that says "Checkout as a new customer".
  3. Validate that the one on the right has a header that says "Checkout using your account".

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Aug 22, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@orlangur orlangur self-assigned this Aug 23, 2017
@orlangur orlangur added this to the August 2017 milestone Aug 23, 2017
@magento-team magento-team merged commit c7de684 into magento:develop Aug 23, 2017
magento-team pushed a commit that referenced this pull request Aug 23, 2017
@ishakhsuvarov
MAGETWO-71833: Grammar fix for #9533 #10627
d52810f
magento-team pushed a commit that referenced this pull request Aug 23, 2017
@ishakhsuvarov
Merge pull request #1433 from magento-engcom/develop-prs
6c5ba1f 
[EngCom] Public Pull Requests
 - MAGETWO-71833: Grammar fix for #9533 #10627
 - MAGETWO-71801: FIX for issue 9930 - Asymmetric Transaction Error with ElasticSearch #10610
 - MAGETWO-71762: Bug fix, prevent displaying 0000-00-00 00:00:00 as anything else in admin grids #10598
 - MAGETWO-71532: Fix swagger-ui on instances of Magento running on a non-standard port #10504
@insanityfarm insanityfarm deleted the fix/authentication_popup_typo branch August 23, 2017 15:13
magento-team pushed a commit that referenced this pull request Oct 10, 2017
MAGETWO-80204: [2.2.x] - Grammar fix for #9533 #10627
58ea0de
magento-team pushed a commit that referenced this pull request Oct 10, 2017
@dvoskoboinikov
Merge pull request #1575 from magento-qwerty/Qwerty-PR20171006
9b87eb0 
Fixed issues:
- MAGETWO-71552: Attribute values on store view level not searchable - for 2.2
- MAGETWO-72866: Redundant indexers invalidation - RIATCS-340
- MAGETWO-75458: [Backport] - Fix overwrite default value image/file with NULL #10253 - for 2.2
- MAGETWO-75460: [Backport] - LowestPriceOptionsProvider returns products without attributes which are used for price calculation (e.g. tax adjustment)
- MAGETWO-80193: [2.2.x] - Add cast to string for CUST_GROUP_ALL #10475
- MAGETWO-80204: [2.2.x] - Grammar fix for #9533 #10627
- MAGETWO-71549: Impossible to export Advanced Prices on a medium profile
- MAGETWO-80198: [2.2.x] - Fix issue #10565 #10575
- MAGETWO-80197: [2.2.x] - Fix JS translation search #10445
- MAGETWO-80195: [2.2.x] - Send different base currency in Google analytics #10508
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur orlangur approved these changes

Assignees

@orlangur orlangur

Labels
Progress: accept
Projects
None yet
Milestone
August 2017
Development

Successfully merging this pull request may close these issues.
5 participants
@insanityfarm @magento-cicd2 @orlangur @magento-team @okorshenko