Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getCacheTags for price issue #10930

Merged
merged 1 commit into from
Sep 19, 2017
Merged

getCacheTags for price issue #10930

merged 1 commit into from
Sep 19, 2017

Conversation

keyurshah070
Copy link
Contributor

@keyurshah070 keyurshah070 commented Sep 17, 2017 •
edited by ishakhsuvarov
Loading

Description

Fixed Issues (if relevant)

  1. getCacheTags for price issue #9877: getCacheTags for price issue
  2. Change the method argument getRateRequest with actual method
  3. Change the test case

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@ishakhsuvarov
Copy link
Contributor

@keyurshah070 Please update PR description with the actual information

@keyurshah070 keyurshah070 changed the title RateRequest method argument change getCacheTags for price issue Sep 17, 2017
@keyurshah070
Copy link
Contributor Author

@ishakhsuvarov updated the PR Description

@magento magento deleted a comment from magento-cicd2 Sep 17, 2017
@ishakhsuvarov ishakhsuvarov added this to the September 2017 milestone Sep 17, 2017
@ishakhsuvarov ishakhsuvarov self-assigned this Sep 18, 2017
@magento-team magento-team merged commit f2dd1a1 into magento:develop Sep 19, 2017
magento-team pushed a commit that referenced this pull request Sep 19, 2017
@ishakhsuvarov
MAGETWO-75328: getCacheTags for price issue #10930
34b2c5a
magento-team pushed a commit that referenced this pull request Sep 19, 2017
@ishakhsuvarov
Merge pull request #1498 from magento-engcom/develop-prs
7d345ff 
[EngCom] Public Pull Requests
 - MAGETWO-75328: getCacheTags for price issue #10930
@denysbabenko denysbabenko mentioned this pull request Sep 30, 2017
Merged
4 tasks
okorshenko pushed a commit that referenced this pull request Oct 4, 2017
@orlangur
MAGETWO-80511: Issue #9877: Backport of: getCacheTags for price issue #…
541ceb3 
…10930 #11154

 - Merge Pull Request #11154 from denysbabenko/magento2:9877
 - Merged commits:
   1. 991ecc7
okorshenko pushed a commit that referenced this pull request Oct 4, 2017
@vrann
MAGETWO-80511: Issue #9877: Backport of: getCacheTags for price issue #…
60424fb 
…10930 #11154
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ishakhsuvarov ishakhsuvarov

Labels
Progress: accept
Projects
None yet
Milestone
September 2017
Development

Successfully merging this pull request may close these issues.
3 participants
@keyurshah070 @ishakhsuvarov @magento-team