opportunistic fix for double ___store=xx&___store=xx #11074
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when we get the current url of the store, oppurtinistically remove the ___store parameter. fixes #10908 the other issues related to parameters given to an url and being removed during store switching should be handled in another ticket Signed-off-by: BlackEagle <[email protected]>
4 tasks
|
I don't think such hack in |
|
@BlackIkeEagle Thank you for providing this hotfix. I will close this pr in favor of #11337 which is more close to fix source of the bug. Hope it will be finished and merged soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when we get the current url of the store, oppurtinistically remove the
___store parameter.
fixes #10908
the other issues related to parameters given to an url and being removed
during store switching should be handled in another ticket
Signed-off-by: BlackEagle [email protected]
Description
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist