Added template as argument to the store address renderer to allow custom formatting #11138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orlangur
approved these changes
Sep 29, 2017
okorshenko
pushed a commit
that referenced
this pull request
Oct 4, 2017
…er to allow custom formatting #11138
|
@jokeputs thanks for your contribution! It was a pleasure to collaborate with you :) |
|
@orlangur, and thank you for the constructive feedback and help with the squash commit. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #10850 for the original pull request.
It's not easy to change the format of the store address used in for example the footer of an e-mail template. By adding the template as an argument in the constructor of
Magento\Store\Model\Address\Rendereryou can easily change it using dependency injection.