Add the 'edition' parameter to getVersion() and getVersionInfo()

[peterjaap]

Add the 'edition' parameter to getVersion() and getVersionInfo() to make it easier for developers to distinguish between Community and Enterprise editions.

Right now we have to do something like this;

$enterprise = Mage::getConfig()->getNode('modules/Enterprise_PageCache/active');
$checkForVersion = ($enterprise ? '1.12' : '1.7.0.0');
if(version_compare(Mage::getVersion(), $checkForVersion, '<')) {
    // do stuff for CE < 1.7.0.0 & EE < 1.12
} else {
    // do stuff for CE > 1.7.0.0 & EE > 1.12
}

Which is not 100% safe since the PageCache extension can be deactivated in an EE installation.

[magento-team]

Hello. Can you provide a clear use case for getting this information? From what we saw it promotes bad code practices. What would you do in a different way for CE and EE?

[peterjaap]

What do you mean by 'bad code practices'? We build & maintain numerous
Magento extensions and sometimes I need to be able to differentiate between
EE and CE, specifically for checking the version. Over time, the templates
change and if I want to rewrite a template by choosing a different template
file through a custom block, I need to be able to accurately differentiate
between versions.

If I use getVersion() now, I get '1.7.0.0', which can both be EE 1.7 (old
version) and CE 1.7 (current version); some template files will differ.

Peter Jaap Blaakmeer
Blaakmeer Webdevelopment
[@] [email protected]
[W] www.blaakmeer.com
[T] +31 (0)50 7001 320

On Thu, Nov 1, 2012 at 5:35 PM, mage2-team [email protected] wrote:

Hello. Can you provide a clear use case for getting this information? From
what we saw it promotes bad code practices. What would you do in a
different way for CE and EE?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/112#issuecomment-9986547.

[amenk]

One nice solution for this would be to equalize the versioning schema for EE and CE. So Magento EE 2.0 and Magento CE 2.0 should use the same code base.

[magento-team]

Hello. We will have a getEdition method implemented/refactored. As for the equalization of versioning - this is a good idea but it is still too early for us to take final decision. Thanks for the tip.

[peterjaap]

For future reference, almost 2 years later (already 3 years ago), it was added in Magento\Framework\App\ProductMetadata; see here.