New Relic: Disables Module Deployments, Creates new Deploy Marker Command

[miguelbalparda]

Description

The "report module enable/disable changes as deployment markers" functionality in the Magento_NewRelicReporting module is broken. Irrespective of actual module enabling/disabling, if New Relic's cron is enabled Magento will send a New Relic Deployment markers for every enabled module once per cron period. This is for an hourly cron and an average of 100 modules in a module system, this is approximatly 2,400 event per individual Magento cron server, per day. This is flooding New Relic's systems with -- let's call it a lot -- of traffic. New Relic is taking steps to drop these deployment requests, but they're still a burden on the system. Also, this creates an almost unusable deployment feature in the New Relic UI. Finally, this creates slow running cron and needless network traffic for individual Magento systems.

This pull requests

1. Disabled the REST API calls to the New Relic API for module deployments
2. Offers a new newrelic:create:deployment command as an alternative for users to create their own deployment markers.

Fixed Issues (if relevant)

Unknown/Not Relevant

Manual testing scenarios

1. Configure New Relic in Stores -> Configuration -> New Relic Reporting
2. Run New Relic cron job
3. In New Relic UI, navigate to Events -> Deployments -- ensure there's no flood of deployment events
4. Run the `$ bin/magento newrelic:create:deploy-marker "A Message" "A Changelog" username command
5. In New Relic UI, navigate to Events -> Deployments
6. Ensure the deployment created by the newrelic:create:deploy-marker command shows up

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

[fooman]

@miguelbalparda I am pretty sure that Alan Storm would still need to sign the CLA as the commit itself (as opposed to the pull request) is coming from his account. Please check with him on the course of action and either close this pull request and re-create with a commit from you or get Alan to sign the CLA.

[okorshenko]

Hi @miguelbalparda
We can not accept this PR without CLA. Sorry

[astormnewrelic]

@okorshenko Does Magento have plans to fix the described event flood behavior themselves, or will you be leaving this less-than-desirable behavior in your open source source product?

[fooman]

Had a chat with Alan and he is happy for me to create this as a pull request instead - see #12477