Fixed occurances of implode with wrong argument order #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RMcLeod79, I just want to inform you that integration tests are failed on base develop branch, that's why tests here won't be green. |
|
This seems to be a problem with the tests rather than my code changes. Look at the 2 Pull Requests before mine, exactly the same failure. |
|
@RMcLeod79, yes, you are right, it started to fail a few days ago. |
|
Internal ticket: MAGETWO-35523 |
magento-team
added a commit
to abeeskau/magento2-community-edition
that referenced
this pull request
Mar 31, 2015
* Fixed bugs
* Wrong capitalization of the label names (the sentence-style capitalization instead of the headline style)
* Inconsistency in the labels in the Admin panel
* Customer menu tabs aren't displayed as selected for the child pages
* An issue with the Active item in the navigation menu in the Blank and Luma themes
* Incorrect price alignment during checkout in the Blank and Luma themes
* Broken field "URL" in the Downloadable product in the Admin panel
* GitHub issues and requests:
* [#1096] (magento/magento2#1096) -- Customer model - getPrimaryAddresses without primary billing address
* [#1114] (magento/magento2#1114) -- GA bug
* [#1116] (magento/magento2#1116) -- Incorrect use of implode()
* [#1126] (magento/magento2#1126) -- Fixed occurrences of implode with wrong argument order
* [#1128] (magento/magento2#1128) -- Change wording for long operation warning
magento-team
added a commit
to abeeskau/magento2-community-edition
that referenced
this pull request
Apr 8, 2015
* Fixed bugs
* Wrong capitalization of the label names (the sentence-style capitalization instead of the headline style)
* Inconsistency in the labels in the Admin panel
* Customer menu tabs aren't displayed as selected for the child pages
* An issue with the Active item in the navigation menu in the Blank and Luma themes
* Incorrect price alignment during checkout in the Blank and Luma themes
* Broken field "URL" in the Downloadable product in the Admin panel
* GitHub issues and requests:
* [#1096] (magento/magento2#1096) -- Customer model - getPrimaryAddresses without primary billing address
* [#1114] (magento/magento2#1114) -- GA bug
* [#1116] (magento/magento2#1116) -- Incorrect use of implode()
* [#1126] (magento/magento2#1126) -- Fixed occurrences of implode with wrong argument order
* [#1128] (magento/magento2#1128) -- Change wording for long operation warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #1116
Although implode accepts it's arguments in any order, the documented order should be used.
Searched the codebase for all occurrences of implode with incorrect argument order and corrected.