Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue 9633 500 error on setup wizard with memcache #11608

Merged
merged 2 commits into from Dec 4, 2017
Merged

Fix for issue 9633 500 error on setup wizard with memcache #11608

merged 2 commits into from Dec 4, 2017

Conversation

ghost
Copy link

@ghost ghost commented Oct 21, 2017

Description

Edits lib/internal/Magento/Framework/Session/Config.php with small change to allow Setup Wizard to work if memcache is set as the save handler in env.php

Fixed Issues (if relevant)

  1. Web Setup Wizard 500 error when session storage is configured to use memcache #9633: Web Setup Wizard 500 error when session storage is configured to use memcache

Manual testing scenarios

  1. Install Magento 2, set sessions to memcache in env.php
  2. Visit setup wizard i.e. store.com/setup/
  3. Should show 500.
  4. Apply fixed Config.php
  5. Load /setup/ , it will now load.

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Oct 21, 2017

CLA assistant check
All committers have signed the CLA.

@kokoc kokoc self-assigned this Nov 7, 2017
@kokoc
Copy link
Member

kokoc commented Nov 7, 2017

Hi @sylink,
Your fix is working great. There are two failures on travis-ci: code style and unit tests. Could you please fix the issues, so we can merge it as is. Otherwise, our internal fixes will override the author on every line of code.

@kokoc kokoc added this to the November 2017 milestone Nov 7, 2017
@kokoc kokoc added 2.2.x bug report Component: Framework/Cache Event: MMNY17 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Component: Setup labels Nov 7, 2017
@ghost
Copy link
Author

ghost commented Nov 8, 2017

I'm not really a developer and I don't know what most of those errors mean. I don't have time to do anything with it either to figure it out, so go nuts on your fixes.

@vkublytskyi vkublytskyi self-assigned this Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report bugfix Component: Framework/Cache Component: Setup Event: MMNY17 Progress: accept Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants