Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10628: Color attribute swatches are not visible if sorting is enabled #12077

Merged
merged 1 commit into from
Nov 13, 2017
Merged

Conversation

RomaKis
Copy link
Contributor

@RomaKis RomaKis commented Nov 7, 2017

Color attribute swatches are not visible if sorting is enabled.

Description

If we added attribute to Used for Sorting in Product Listing it tried to cache it while making custom query. So the attribute don't has all needed parameters. Now we cache such attributes with all additional data.

Fixed Issues (if relevant)

  1. Color attribute swatches are not visible if sorting is enabled #10628: Color attribute swatches are not visible if sorting is enabled

Manual testing scenarios

  1. Magento with sample data is installed.
  2. For the color attribute enabled option Used in Product Listing (Stores->Attributes->Product-> select color attribute->Storefront Properties->Used for Sorting in Product Listing->select Yes).
  3. Make search by "red" keyword.
  4. List of results should be shown. Color attribute should be presented in configurable attributes.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Nov 7, 2017
@okorshenko okorshenko removed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Nov 7, 2017
@ishakhsuvarov ishakhsuvarov self-assigned this Nov 8, 2017
@ishakhsuvarov ishakhsuvarov added this to the November 2017 milestone Nov 8, 2017
@okorshenko okorshenko merged commit 774799a into magento:2.2-develop Nov 13, 2017
okorshenko pushed a commit that referenced this pull request Nov 13, 2017
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Nov 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixed in 2.2.x The issue has been fixed in 2.2 release line Progress: accept Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants