12180 Remove unnecessary use operator for Context, causes 503 error i… #12220
Conversation
…n account address book.
|
|
|
@chris-pook could you please sign CLA? |
|
CLA signed. Thanks |
| @@ -8,7 +8,6 @@ | |||
| use Magento\Customer\Api\AddressMetadataInterface; | |||
| use Magento\Customer\Api\AddressMetadataManagementInterface; | |||
| use Magento\Customer\Model\Metadata\AttributeResolver; | |||
| use Magento\Framework\App\Helper\Context; | |||
There was a problem hiding this comment.
Hi @chris-pook, please check a872f40#diff-fe978939bb978f6074e10338e0b14791
I believe the fix is not correct, helper context is supposed to be injected, not customer model context.
At least parent class expects Magento\Framework\App\Helper\Context.
Could you please replace import with Magento\Framework\App\Helper\Context as HelperContext instead and change other places in class accordingly?
There was a problem hiding this comment.
Sorry @orlangur , you've lost me.. Customer\Model\AttributeChecker (where my change is) has no parent class. This change I have made is in Customer\Model\AttributeChecker where there is a use statement for Magento\Framework\App\Helper\Context which is never used in the class. I could alias this to HelperContext but it is not used so better to remove I think? Unless I'm missing something here?
There was a problem hiding this comment.
@chris-pook, my bad, I was opening AttributeChecker.php in my IDE and didn't notice I'm checking helper and not model with the same name.
Looks good to me now after your explanation :)
There was a problem hiding this comment.
Ah good stuff! Thanks
|
Hello @chris-pook, please check my comment #12220 (comment). |
[EngCom] Public Pull Requests - 2.2-develop - MAGETWO-85311: Added namespace to product videos fotorama events #12469 #991 - MAGETWO-85300: 8437: Silent error when an email template is not found #970 - MAGETWO-85293: 12613: Verbiage Update Required: Product Image Watermark size Validation Message. #985 - MAGETWO-85286: 8176: LinkManagement::getChildren() does not include product visibility. #986 - MAGETWO-85285: 12482: Sitemap image links in MultiStore #935 - MAGETWO-84955: Set Current Store from Store Code if isUseStoreInUrl #12529 - MAGETWO-84764: NewRelic: Disables Module Deployments, Creates new Deploy Marker Command #12477 - MAGETWO-84439: 12180 Remove unnecessary use operator for Context, causes 503 error i… #12220
…n account address book.
Removing an unnecessary "use" to prevent a 503 error in account address book page.
Description
Remove the unnecessary "use".
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist