Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport to 2.1-develop] Fix #9243 - Upgrade ZF components. Zend_Service #12958

Merged
merged 1 commit into from
Jan 8, 2018
Merged

[Backport to 2.1-develop] Fix #9243 - Upgrade ZF components. Zend_Service #12958

merged 1 commit into from
Jan 8, 2018

Conversation

dverkade
Copy link
Member

@dverkade dverkade commented Jan 2, 2018

Resolved issue #9243:

  • Removed Magento\Framework\Locale\CurrencyInterface from setService method and changed it to \Zend_Currency_CurrencyInterface which must be provider to this function.
  • Changed return type to \Zend_Currency_CurrencyInterface, the given instance of the service is returned by the setService function
  • Removed \Zend_Service from getService method and changed it to \Zend_Currency_CurrencyInterface
  • Added @deprecated tags to both methods and added @see annotation to the methods. Referenced corresponding interface \Magento\Directory\Model\Currency\Import\ImportInterface

Backport

Backport of #11291

@dverkade
Resolved issue #9243:
abc7bc6 
- Removed Magento\Framework\Locale\CurrencyInterface from setService method and changed it to \Zend_Currency_CurrencyInterface which must be provider to this function.
- Changed return type to \Zend_Currency_CurrencyInterface, the given instance of the service is returned by the setService function
- Removed \Zend_Service from getService method and changed it to \Zend_Currency_CurrencyInterface
- Added @deprecated tags to both methods and added @see annotation to the methods. Referenced corresponding interface \Magento\Directory\Model\Currency\Import\ImportInterface
@ishakhsuvarov ishakhsuvarov self-assigned this Jan 3, 2018
@ishakhsuvarov ishakhsuvarov added this to the January 2018 milestone Jan 3, 2018
@okorshenko okorshenko mentioned this pull request Jan 8, 2018
Closed
@magento-team magento-team merged commit abc7bc6 into magento:2.1-develop Jan 8, 2018
magento-team pushed a commit that referenced this pull request Jan 8, 2018
MAGETWO-86300: [Backport to 2.1-develop] Fix #9243 - Upgrade ZF compo…
d688406 
…nents. Zend_Service #12958
@magento-engcom-team magento-engcom-team added Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line labels Jan 8, 2018
@dverkade dverkade deleted the 2.1-Upgrade-ZF-components.-Zend_Service branch June 22, 2018 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ishakhsuvarov ishakhsuvarov

Labels
Community Insider: Cream community-insider-contribution Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Progress: accept Release Line: 2.1 up for grabs
Projects
None yet
Milestone
January 2018
Development

Successfully merging this pull request may close these issues.
4 participants
@dverkade @magento-team @ishakhsuvarov @magento-engcom-team