Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding dispatch of an event before and after applyAllUpdates() #14

Closed
wants to merge 1 commit into from
Closed

Conversation

brobie
Copy link
Contributor

@brobie brobie commented Apr 26, 2012

This allows for the ability to put in a mechanism to prevent errors from
being displayed to users if more than one make a request in the same
span of time that the install/upgrade scripts are running.

This mechanism could be: waiting, sending to an separate page, etc.

Now, we would not have to turn on maintenance mode...potentially.

This allows for the ability to put in a mechanism to prevent errors
being displayed to users if more than one make a request in the same
span of time that the install/upgrade scripts are running.  

This mechanism could be: waiting, sending to an seperate page, etc.  

Now, we would not have to turn on maintainence mode...potentially.
@magento-team
Copy link
Contributor

Hi @brobie and @colinmollenhour,

we're going to implement independent install/upgrade application in approximately 4th Quarter of 2012, before Magento 2 stable release. This application should resolve any issues with installing/upgrading Magento, including described in this thread.

While it's not implemented yet, you can use @colinmollenhour's script where it's possible. But generally we don't recommend upgrading on production system.

Looks like @brobie's proposal should be considered carefully. The point is that it's impossible now to determine on dispatching 'apply_db_schema_updates_before' event if any upgrade will be executed. As a result a method which observes this event will be executed every time the page is loading, regardless of upgrade process will be run or not. It can produce redirecting (or any other action provided by the observer) for some visitors even if no upgrade is running.

Closing the request and thank you for the proposal.

@askwhyweb askwhyweb mentioned this pull request Dec 18, 2014
@sivajik34 sivajik34 mentioned this pull request Jan 2, 2015
magento-team pushed a commit that referenced this pull request Jan 9, 2015
…e-include-path

[Extensibility] Magetwo 30808 remove include path
adamzero1 pushed a commit to adamzero1/magento2 that referenced this pull request Feb 26, 2023
@makkoff makkoff mentioned this pull request May 30, 2023
5 tasks
@nabeelfocus nabeelfocus mentioned this pull request Jan 3, 2024
5 tasks
@FabXav FabXav mentioned this pull request Oct 11, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants