Fixes issue with reading store config for store with code of 'default' #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…load associated config valueues when not configured as default store.
|
@davidalger Thank you for the provided fix, it looks good. We should be able to accept it if all tests pass on our CICD. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug where if you setup a store with a store code of 'default' and also have another store configured as the default store on the given website, the config values for the configured default store would be loaded when requesting the config for the
store|defaultscope code. This results in the system displaying and using incorrect config values.I've update the unit test to guarantee that this does not happen happen again within the affected method by mocking a default store, which if by the tested method will break the test. Also corrected the method so it correctly loads the correct config based on the passed in store code regardless of what that code may be.