Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Responsive Design Footers bottom of screen on mobile devices #15118 #15353

Merged
merged 1 commit into from
May 23, 2018
Merged

Responsive Design Footers bottom of screen on mobile devices #15118 #15353

merged 1 commit into from
May 23, 2018

Conversation

chirag-wagento
Copy link
Contributor

@chirag-wagento chirag-wagento commented May 19, 2018 •
edited by sidolov
Loading

Solved footer issue for mobile view

Description

Solved footer issue for mobile view

Fixed Issues (if relevant)

  1. Responsive Design, Footers do not snap to bottom of screen on mobile devices #15118: Responsive Design, Footers do not snap to bottom of screen on mobile devices
  2. ...

Manual testing scenarios

  1. Check footer in mobile

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented May 19, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team magento-engcom-team added this to the May 2018 milestone May 20, 2018
@magento-engcom-team magento-engcom-team added Release Line: 2.2 Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept labels May 20, 2018
@magento-engcom-team magento-engcom-team mentioned this pull request May 23, 2018
Closed
magento-team pushed a commit that referenced this pull request May 23, 2018
ENGCOM-1606: Responsive Design Footers bottom of screen on mobile dev…
e623b76 
…ices #15118 #15353
magento-team pushed a commit that referenced this pull request May 23, 2018
ENGCOM-1606: Responsive Design Footers bottom of screen on mobile dev…
a86e302 
…ices #15118 #15353
@magento-engcom-team magento-engcom-team merged commit eef111f into magento:2.2-develop May 23, 2018
@magento-engcom-team
Copy link
Contributor

Hi @chirag-wagento. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Please, consider porting this solution across release lines.
You may use Porting tool to port commits automatically.

This was referenced Jun 4, 2018
Merged
Closed
Merged
Closed
This was referenced Jun 6, 2018
Closed
Closed
@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Jul 16, 2018 •
edited
Loading

Hi @chirag-wagento,

Looks like your PR introduced new issue on mobile on sign in page - footer overlaps "New Customers" section
pr-16595 engcom dev magento com_customer_account_login_referer_ahr0chm6ly9wci0xnju5ns5lbmdjb20uzgv2lm1hz2vudg8uy29tl2n1c3rvbwvyl2fjy291bnqvzm9yz290cgfzc3dvcmqv_ iphone 6_7_8 plus

This was referenced Jul 22, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sidolov sidolov

Labels
Event: dmcdindia Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Milestone
May 2018
Development

Successfully merging this pull request may close these issues.
6 participants
@chirag-wagento @magento-cicd2 @magento-engcom-team @ihor-sviziev @vijay-wagento @sidolov