Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] Resolve Knockout non-unique elements id in console error #15732

Conversation

vijay-wagento
Copy link

Original Pull Request

#15349
When enabling more than one payment methods from admin, It is giving an error in the console "Found elements with non-unique id billing-address-form "

Description

Fixed Issues (if relevant)

  1. Multiple Payment Methods Enabled is giving error in console "Found 3 Elements with non - unique Id" #15348:
  2. Issue titleMultiple Payment Methods Enabled is giving error in console "Found 3 Elements with non - unique Id"

Manual testing scenarios

  1. Login to Admin Panel > Sales> Payment Methods
  2. Enable more than one of Magento payment methods for checkout
  3. Add a product to the cart, press F12 to check the console log in the browser

Expected Result

It should not show any error in the console

Actual result

screenshot from 2018-05-19 14-10-36

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @vijay-wagento. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Component: Checkout Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants