Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] Fix for Magnifier in inside mode #15749

Conversation

vijay-wagento
Copy link

Original Pull Request

#15382

Fixed Issues

  1. Magnifier doesn't work with mode set to inner #4977: Magnifier doesn't work with mode set to inner

Manual testing scenarios

You need to change the magnifier's configuration options in the file: app/design/frontend/Magento/luma/etc/view.xml

Set the following values ​​for these lines:

<var name="enabled">true</var>
<var name="mode">inside</var>

@VladimirZaets
Copy link
Contributor

VladimirZaets commented Jun 7, 2018

Hi, @vijay-wagento , thank you for collaboration.
This fix works wrong on Magento 2.3 branch.
Magnifier doesn't hide when the cursor was the moved out from the image.
Also, the image isn't resized by container size, as it occurs in 2.2 branch
2.3 branch
image 2
2.2 branch
image 3

@vijay-wagento
Copy link
Author

Hello @VladimirZaets
Let me take a look,
Thanks,

@VladimirZaets
Copy link
Contributor

Hi @vijay-wagento, I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for collaboration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants