Fixed Responsive Design, Footers bottom of screen on mobile devices

[chirag-wagento]

Fix footer responsive issue

Description

Fixed Issues (if relevant)

1. Responsive Design, Footers do not snap to bottom of screen on mobile devices #15118:
   Responsive Design, Footers do not snap to bottom of screen on mobile devices

Manual testing scenarios

1. Check responsive footer

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @chirag-wagento. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[VladimirZaets]

Hi, @chirag-wagento , thank you for collaboration.
The body node can't have height:100% style.
Please look comments here

[chirag-wagento]

@VladimirZaets I have committed new cod with new changes now you can check it.
I can see 100% body height. Now You can check it.
You can see attached screenshot

Thanks

[DanielRuf]

Try to scroll down a bit, the body will not end at the end of the document.

[chirag-wagento]

@DanielRuf Please review above comment and screenshot.
Can you give me issue screenshot.

My changes are in Branch fix-footer-responsive-mobile. You can check it.

Thanks

[chirag-wagento]

@VladimirZaets

Any update in this PR?

Thanks

[VladimirZaets]

Hi @chirag-wagento Please scroll your page down and make the screenshot. You will see the bug if to do that.

[VladimirZaets]

@magento-engcom-team give me test instance

[magento-engcom-team]

Hi @VladimirZaets. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @VladimirZaets, here is your new Magento instance.
Admin access: https://pr-16323.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Please make sure you are PR author or assignee to access the instance.

[DanielRuf]

Should be (at least) display:inline-block + width: 100%;.

[DanielRuf]

inline is not for block elements like this one so this is still not correct ;-)

[chirag-wagento]

@DanielRuf inline-block + width: 100% also incorrect because there are problem with content as per this #15471 (comment)
So I will use display: inline-grid.

[chirag-wagento]

@DanielRuf and @VladimirZaets I have changed my code please check.

Thanks

[VladimirZaets]

@chirag-wagento Please looks this example http://jsfiddle.net/webtiki/h9mHc/

[DanielRuf]

@DanielRuf inline-block + width: 100% also incorrect because there are problem with content as per this #15471 (comment)

No, and inline-grid is not correct or supported by all browsers.

[chirag-wagento]

@DanielRuf Ok i will close my PR. You can do this.