Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[forwardport] fix #16764 Rating Star issue on Product detail Page. #16808

Merged
merged 1 commit into from
Jul 18, 2018
Merged

Conversation

Karlasa
Copy link
Contributor

@Karlasa Karlasa commented Jul 14, 2018

Description

Forwardport of PR #16766

Changed focus to hover, because field validation focuses first incorrect field

Fixed Issues (if relevant)

  1. Rating Star issue on Product detail Page.  #16764: Rating Star issue on Product detail Page.

Manual testing scenarios

1.Go to product page
2.submit review without any input
Expected result:
rating stars show message "Please select one of each of the ratings above"
Actual result:
Shows message "Please select one of each of the ratings above" and first star is in focus (shows as filled star)

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

@Karlasa Karlasa deleted the FP-PR-16766 branch July 21, 2018 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants